-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal key combinations not working properly #7077
Comments
So the regular Powershell terminal supports selection using those keybindings? Interesting that ctrl+arrow doesn't skip the word, that works fine on bash. |
ctrl + backspace in powershell is also not working. It only removes one character, while in native powershell and powershell launched through native cmd it removes the whole previous word. Edit: Nevermind, it appears that ctrl + backspace doesn't delete the whole word on 32 bit powershell, which is what I was running in VSCode. |
In the latest insider's release ctrl + left/right no longer produce '5D/5C', but only move one character at a time rather than whole words. ctrl + c produces nothing rather than '^c'. |
Thanks @AAurelianus, it looks like the adoption of xterm.js has improved the powershell situation 🎆 Here is the open issue for ctrl+arrow xtermjs/xterm.js#65 (it happens on Linux/bash too). |
@Tyriar actually my previous comment on ctrl + backspace does apply. In native powershell the sequence deletes whole words, in powershell in the integrated terminal it only deletes single characters, the same as unmodified backspace. This is both on 1.2.0 and the 2016-6-10 Insider release. |
@gerane, I think the functionality for those keys is driven by PSReadline, not the terminal itself. The terminal does seem to load PSReadline okay (the color highlighting works, no errors get thrown) but some of the functionality is lost. This might be due to the implementation of PSReadline? |
is this already being worked on or is it something I could create a PR for? |
@codymullins not being worked on right now, I'm guessing its a problem within the https://github.com/sourcelair/xterm.js code base though (or the oldish https://github.com/rprichard/winpty version it uses when hooked up with pty.js). |
Using vscode with windows native command line also the same problem with ctrl key |
@Thaina ctrl+left/right in cmd.exe should work fine in the current insiders https://code.visualstudio.com/insiders |
Is it possible to build |
Closing this off in favor of #11314 (blocking upstream issue: xtermjs/xterm.js#487) |
Steps to Reproduce:
The text was updated successfully, but these errors were encountered: