Support copy and paste via keyboard on integrated terminal

[Tyriar]

Integrated terminal master issue: #143

Might need to use custom keybindings, ctrl+c terminates a process. Also it's probably not best to hijack ctrl+shift+c from open in new terminal.

[Tyriar]

Probably best left for after xterm is adopted.

[Tyriar]

Upstream issue blocking configurable copy/paste: xtermjs/xterm.js#118

xterm.js did recently add ctrl+insert to copy and shift+insert to paste in xtermjs/xterm.js#107, so this will be the 'workaround' until xtermjs/xterm.js#118 gets done.

[mniak]

I'm also facing Issues with ctrl+C and other simmilar copy-paste shortcuts in the integrated terminal on Windows. I'm not sure what would be the best solution to this issue. Some people would enjoy copying and pasting using the default OS keyboard shortcuts, but it would be difficult to break a current running process (except for OS X). I strongly use this shortcut.

I'd rather remove the shortcut indicator in the right-button-menu for copy/paste/cut to avoid misunderstandings.

[Tyriar]

Basic support is there for v1.3.0 using:

• ctrl+insert to copy
• shift+insert to paste

This will be improved in the future with the ability to specify your preference in keybindings.json.

[bldesign]

Maybe integrated terminal can present same feature as native Windows terminal, on Windows.

In the property options there are edition options with the ability to active ctrl shortcuts. It's just what we are talking about. It kills the process only if there is no selection. Cool no? VS Code can do it.

Sorry my preview is in french, but yours certainly looks the same.

With all options enabled. You can:

1. Copy paste ctrl + c / v even when a process is running (kills only if no selection)
2. Always paste ctrl + v (after process ended)
3. Select text with mouse
4. Select text with keyboard shift + ← / →

You can copy, paste and select text only with keyboard on Windows.
(Both terminal, integrated and not are Microsoft Windows [version 10.0.10586])

Can you expose these options to user preferences?

[mniak]

Killing the process only if there is no selection

A very good idea

[Tyriar]

@bldesign @andregsilv nice suggestion, forked to #8818 to be considered after this.

[Tyriar]

Proper keybinding support coming in v1.4.0!

Certain key combinations won't work as the terminal will consume them before VS Code has a chance to respond. This is being tracked in #7269

[Tyriar]

Reopening as these keybindings should be disabled on Mac since cmd+c and cmd+v work there.

[alexsorokoletov]

unfortunately ctrl+insert/shift+insert is not the ideal way to have shortcuts on windows. Macbooks don't have insert key.

[Tyriar]

@alexsorokoletov cmd+c and cmd+v should work on Mac.

[alexsorokoletov]

@Tyriar hardware is mac, however the OS is Windows 10. Sorry for the confusion

[Tyriar]

@alexsorokoletov ah, I guess you have to wait until next release then or use the Insiders build for ctrl+shift+c/v.

[superDuperCyberTechno]

So, it has been implemented, although I cannot seem to change the shortcut. I tried switching it to ctrl+c/ctrl+v without luck. All other custom keybindings work fine.

[Tyriar]

@superDuperCyberTechno you can change the keybinding, but you can only change it to certain combinations as the key strokes at handled by the terminal before vscode itself. This is the reason F1 and ctrl+p do no work but ctrl+shift+p works fine. The "fix" for this would be to address #7269 (comment)

[superDuperCyberTechno]

Alright, thank you for the explanation. Makes sense that ctrl+c is bound to the cancel action in the console (bash, at least). I'll just stick to the default keybinding for now, then...

[Tyriar]

@superDuperCyberTechno I just pushed a fix for #7269 which will landin Insiders tomorrow (or v1.5.0 stable) to allow a set of commands to skip over the shell processing and be handled by VS Code. This means that you can indeed rebind to ctrl+c and ctrl+v if you want, you will not be able to use ctrl+c to cancel the command anymore though and you cannot remap that (outside of maybe remapping in bash if that's possible).

Conditional ctrl+c/v if probably what you really want, this is still open and captured in #8818