Allow Ctrl/Shift + insert to copy/paste on windows and linux #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many systems (including MS Windows and many linuxes) map `<Ctrl>` + `<Insert>` to copy and `<Shift> + <Insert>` to paste. That serves as a handy fallback when the more common `<Ctrl> + C` and `<Ctrl> + V` keybindings have their default prevented to send signals to the terminal. Currently all keydown-events with the insert key send `\x1b[2~` to the terminal. This commit won't send that key if either the `shiftKey` or the `ctrlKey` are present. Instead it will enable `contentEditable` to allow for pasting.
runarberg
force-pushed
the
fix/ctrl-or-shift-insert-copy-pasting
branch
from
74b1a50 to
524db02
Compare
|
Ideally this should be configurable, I'd like VS Code users to be able to use their preferred method (the default of which will probably be ctrl|cmd+shift+c/v).
Perhaps allowing consumers to do more generic mappings would be a good idea? Also shift+insert at least on |
|
While I agree with @Tyriar that some kind of customization/extensibility considering key bindings, I do not believe that this is blocking at the moment. This PR works 👍 . LGTM. |
This was referenced Jun 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many systems (including MS Windows and many linuxes) map Ctrl + Insert to copy and Shift + Insert to paste. That serves as a handy fallback when the more common Ctrl + C and Ctrl + V keybindings have their default prevented to send signals to the terminal.
Currently all keydown-events with the insert key send
\x1b[2~to the terminal. Instead this PR won’t send anything if either theshiftKeyor thectrlKeyare present in the event. Also it will enablecontentEditablewhenshiftKeyis present to allow for pasting in Firefox and Edge.