Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test handling of multiple formatters #71093

Closed
2 tasks done
jrieken opened this issue Mar 25, 2019 · 1 comment
Closed
2 tasks done

Test handling of multiple formatters #71093

jrieken opened this issue Mar 25, 2019 · 1 comment

Comments

@jrieken
Copy link
Member

jrieken commented Mar 25, 2019

Refs: #41882

Complexity: 3

We have improved the behaviour when having multiple formatters for a document. Install 'conflicting' formatter extensions like beautify and/or prettier and test that

  • there are new actions 'Format Document With...' and 'Format Selection With...' which show quick pick allowing you to select an extension that's used to format
  • clicking the gear icon in the formatter pick opens the extensions viewlet for that extension - allows to configure/disable/uninstall it
  • there is also 'Format Document' and 'Format Selection' which in case of multiple extensions just pick one and then print on the status bar which it picked
  • format on save and format on paste also print to status bar which formatter was selected, also only when multiple formatters exists

*Note that format selection only shows when an extension contributes such a provider.

@octref
Copy link
Contributor

octref commented Mar 26, 2019

Great work 👍

@octref octref closed this as completed Mar 26, 2019
@octref octref removed their assignment Mar 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants