Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format actions overkill in context menu #71170

Closed
isidorn opened this issue Mar 26, 2019 · 3 comments
Closed

Format actions overkill in context menu #71170

isidorn opened this issue Mar 26, 2019 · 3 comments
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 26, 2019

Refs: #71093

  1. Have prettier, beautify installed.
  2. Open typescript file
  3. Select something -> context menu

Notice there are 4 commands regarding formating. Even though I understand the differences I think this is overkill. Instead of that I suggest to just show 2 commands in the context menu, and still show all 4 in the command palette.
If you really want to force the user to disable some formatter then I suggest to only show the "Format With..." commands.

Screenshot 2019-03-26 at 14 40 09

@jrieken jrieken added the *as-designed Described behavior is as designed label Mar 26, 2019
@vscodebot
Copy link

vscodebot bot commented Mar 26, 2019

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Mar 26, 2019
@jrieken
Copy link
Member

jrieken commented Mar 26, 2019

If you really want to force the user to disable some formatter then I suggest to only show the "Format With..." commands.

We are not going in circles here. That's exactly what we had three days ago and people didn't like it. I think having a selection, multiple formatters, and the context menu open happens seldom and when it happens then it represents the state of your installation.

@octref
Copy link
Contributor

octref commented Mar 26, 2019

If you really want to force the user to disable some formatter

Once you have only one formatter left, the context menu, the command palette and the status bar all get cleaner. That's a well designed incentive for users to only enable 1 formatter for a filetype 👍

@vscodebot vscodebot bot locked and limited conversation to collaborators May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

3 participants