Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test @types/vscode and vscode-test #74436

Closed
3 tasks done
octref opened this issue May 28, 2019 · 5 comments
Closed
3 tasks done

Test @types/vscode and vscode-test #74436

octref opened this issue May 28, 2019 · 5 comments

Comments

@octref
Copy link
Contributor

octref commented May 28, 2019

Test for #71048

Complexity: 2

Overview: vscode has been split into @types/vscode and vscode-test. See the reasoning here: microsoft/vscode-extension-vscode#147

Release notes | Docs

Please test:

@bpasero
Copy link
Member

bpasero commented May 29, 2019

I skiped over the "VSCE" part.

@aeschli
Copy link
Contributor

aeschli commented May 29, 2019

Documentation link does not work for me

@octref
Copy link
Contributor Author

octref commented May 29, 2019

Fixed link

@octref
Copy link
Contributor Author

octref commented May 30, 2019

I thought it's mostly going to be small changes, but the API parts need some discussion which I don't have bandwidth for. I pulled it out from release notes and will continue in June. Thanks for testing!

@aeschli
Copy link
Contributor

aeschli commented Jun 4, 2019

Created branch https://github.com/microsoft/vscode-generator-code/tree/vscode-test-and-types-at-code with all the commits.
Set master back to the previous version to avoid that the changes get pushed inadvertently

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 13, 2019
@Tyriar Tyriar removed their assignment Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants