Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engineering work for vscode-test and @types/vscode #71048

Closed
7 of 8 tasks
octref opened this issue Mar 25, 2019 · 2 comments
Closed
7 of 8 tasks

Engineering work for vscode-test and @types/vscode #71048

octref opened this issue Mar 25, 2019 · 2 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc. on-testplan
Milestone

Comments

@octref
Copy link
Contributor

octref commented Mar 25, 2019

In continuation of #70175. There a few things I'd want to sort out before we can recommend people switching to vscode-test and @types/vscode

Already done:

For @types/vscode

For vscode-test:

@octref octref added the engineering VS Code - Build / issue tracking / etc. label Mar 25, 2019
@octref octref self-assigned this Mar 25, 2019
@octref octref modified the milestones: Backlog, May 2019 Mar 25, 2019
octref added a commit to microsoft/vscode-vsce that referenced this issue May 23, 2019
octref added a commit to microsoft/vscode-generator-code that referenced this issue May 24, 2019
@octref octref closed this as completed May 28, 2019
aeschli added a commit to microsoft/vscode-generator-code that referenced this issue May 28, 2019
@Xanewok
Copy link
Contributor

Xanewok commented Jun 27, 2019

Thanks a lot @octref for the related work on supporting the vscode types and test runner in a more npm-first-class manner! This seemed like a wart last time I refreshed the rls-vscode extension (Rust support), so I'd consider the work very needed.

Is there a timeline on when it is recommended to switch over to @types/vscode and vscode-test? Maybe it's safe already to switch to @types/vscode already?

Xanewok added a commit to Xanewok/rls-vscode that referenced this issue Jun 27, 2019
@octref
Copy link
Contributor Author

octref commented Jun 27, 2019

@Xanewok You can wait until next Wednesday for new release, or read the to-be-released docs here:

Maybe it's safe already to switch to @types/vscode already?

Yes, you can switch already.

Xanewok added a commit to Xanewok/rls-vscode that referenced this issue Jun 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. on-testplan
Projects
None yet
Development

No branches or pull requests

2 participants