Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate: macOS notarization #74782

Closed
bpasero opened this issue Jun 3, 2019 · 17 comments · Fixed by #86588
Closed

Investigate: macOS notarization #74782

bpasero opened this issue Jun 3, 2019 · 17 comments · Fixed by #86588
Assignees
Labels
engineering VS Code - Build / issue tracking / etc. macos Issues with VS Code on MAC/OS X macos-catalina vscode-build VS Code build process issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 3, 2019

https://developer.apple.com/documentation/security/notarizing_your_app_before_distribution

and

electron/electron#18609

//cc @joaomoreno

If VSCode fails to launch VSCode on macOS Catalina do this:

image

@bpasero
Copy link
Member Author

bpasero commented Sep 4, 2019

Looks like hardening is only required beginning 2020: https://developer.apple.com/news/?id=09032019a

@AndrewPrifer
Copy link

@bpasero only the notarization prerequisites have been loosened till 2020, notarization is still very much required if we want to get rid of the security warning.

@cutecycle
Copy link

We're having this issue on a Catalina upgrade, except we can't even open the application.

@miguelsolorio
Copy link
Contributor

@cutecycle see the main issue description for how to get around this. You can also right-click on the app and click "Open" to get the option to open it:

image

@cutecycle
Copy link

@misolori Open Anyway doesn't appear in Catalina.

@miguelsolorio
Copy link
Contributor

@cutecycle does the right-click method work for you?

@gourav
Copy link

gourav commented Oct 12, 2019

@misolori No. Open does not even appear anymore.
image

If you right click on .app, and choose open, you get "Open Anyway".

@bkowshik
Copy link

bkowshik commented Oct 13, 2019

I was able to install Visual Studio Code on Catalina using the following steps:

  1. Double-click the installer to get, “Visual Studio Code” can’t be opened because Apple cannot check it for malicious software. message
  2. Open Security & Privacy settings page to see the Open Anyway button
  3. One more window and one should be inside VS Code

Screenshot 2019-10-13 at 7 25 02 PM

@yrest
Copy link

yrest commented Oct 13, 2019

Same issue, workaround works fine! Any update on plans to submit VSCode to Apple?

@bpasero
Copy link
Member Author

bpasero commented Dec 5, 2019

This may slip to December, but @joaomoreno already started on this 🍻

@justlurking
Copy link

This may slip to December, but @joaomoreno already started on this 🍻

Any update on this @joaomoreno @bpasero? Hoping this will be resolved in 1.41.1 before the holidays and we won't have to wait until January?

@bpasero
Copy link
Member Author

bpasero commented Dec 19, 2019

This is in progress and should be done by our January release.

@microsoft microsoft locked as off-topic and limited conversation to collaborators Dec 19, 2019
@joaomoreno
Copy link
Member

Starting next week, insider builds should be properly notarized. ✔️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. macos Issues with VS Code on MAC/OS X macos-catalina vscode-build VS Code build process issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.