Remote Smoke: Goto page finds welcome page on remove

[aeschli]

Running the remote smoketest against a build shows that search returns more results in a remote window than in a local window.

In a remote window, the results contains the welcome page, where as in a regular window they don't.

• checkout distro
• Run yarn smoketest --remote --build ~/vscode/1.35.0-insiders/VSCode-linux-x64/

I added a workaround so the smoke tests passes:

vscode/test/smoke/src/areas/multiroot/multiroot.test.ts

Line 50 in be547e2

const numResultsExpected = this.app.remote ? 7 : 6;

[roblourens]

We handle this for text search but not file search. I can't repro in the product with *.* but I can by just searching 'welcome' with the welcome page open.

[aeschli]

The workaround is still there:

vscode/test/smoke/src/areas/multiroot/multiroot.test.ts

Line 50 in be547e2

const numResultsExpected = this.app.remote ? 7 : 6;

Shouldn't it be gone a result of the fix?

[roblourens]

Fixed, thanks