-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide commands to split the terminal #7504
Comments
Are you proposing to be able to split the panel side by side like the editor? |
@Tyriar oh I see so the terminal itself would split in the panel, we would not add splitting support to the panel? |
Another issue that's related to this: Add maximize panel command #7314 |
Would be great to be able to split integrated terminal / task output in the bottom pane. |
@bargeruns that would be this one #7161 😃 |
Personally I prefer sticky tabbing instead of window splitting as the window size is always too small ... something like tmux window would be great :) |
Reopening, I'm probably not going to learn tmux personally but would definitely find this useful. Also I don't think there is a solution on Windows. |
And I'm not sure tmux/screen would help those of us who use PowerShell in their terminal window. |
@rkeithhill yeah that's one of the reasons I reopened, there's a similar discussion on this topic in #10546 |
@Tyriar |
So I set my shell to Now tmux can only cover half the width of the terminal instead of all of it 🤔 Opened a new issue since this a bug: #24630 |
@Tyriar Isn't it possible anyhow currently create a terminal in editor pane? (via API)? |
@whitecolor track that in this issue #2806 |
It's to split, focusing is done by the mouse cursor(perhaps Tab when screenreader mode). |
@jens1o ah ok, currently the thinking is to just have a split horizontal/vertical as opposed to split to left/right to simplify it a bit. Good to know though 😃 |
Focusing right/left would be v nice. |
key bindings are one of the first things I change post vscode install.
|
Here's an update of things that have changed since my last comment:
We also decided to restrict splitting to a single dimension for the time being to simplify the UX and implementation. We could always add splitting both vertically and horizontally at the same time later if needed (eg. if you can pull the terminal/panel out into a different window or #34442 in the future). Most of this will be in Monday's build in a few days. Things left to do:
|
This is awesome news! Thanks @Tyriar 🙏 |
Thanks @Tyriar great implementation 🙏 |
I would propose selecting a different keybinding for Windows, since this would override the default keybindings of PSReadLine, which comes preinstalled since PowerShell 5. |
@felixse we generally stay away from alt for default keybindings, ctrl+shift+d has other issues though as it is used to toggle the debug viewlet. |
@Tyriar Great work. This may be far fledged. But can this be a future implementation: https://user-images.githubusercontent.com/688617/30918650-2a2db238-a36d-11e7-95ff-8bb25b6d43fe.gif This was mentioned by @plmrry in #10546 Cheers for the great work you guys do. |
@tvvignesh you would probably also be able to do that if these 2 issues got resolve #10546 #14909 |
@Tyriar BTW, I suggest to create a new repo which has only the terminal part (maybe we can also keep the extension part), and let anyone others to contribute to this magical powershell console. |
I've pushed a change to the keybindings, cmd+d has been dropping in favor of ctrl/cmd+\ so that splitting the terminal uses the same keybinding as the editor: Primary: ctrl+\ (mac: cmd+) |
Am using this now. I will never go back. |
This is awesome! What's the keybinding for switching keyboard focus between split windows? |
@willisplummer alt+arrow or cmd+alt+arrow |
@Tyriar I haven't been able to find quick keybind or command for closing the currently focused terminal panel. Is that possible/in the works? |
@brennongs I was looking for the same thing. Turns out you can add a key binding for {
"key": "cmd+w",
"command": "workbench.action.terminal.kill",
"when": "terminalFocus"
} (in |
@Tyriar what about splitting terminal horizontally? |
@brennongs there is no default keybinding for this. @whitecolor you can only do that if the panel is vertical currently. See #7504 (comment) |
@Tyriar ok I didn't notice that it can be veritical. Maybe if it would be possible to have multiple terminal panes as editor panes and possible to split editor panes vertically and horizontally (like in VIM). Then there would be no need for terminal's split. =) |
@whitecolor there's a different between splitting tabs in multiple directions and splitting panes though. |
After multiple terminals are added, it would be useful to see multiple terminals at once. Open question: how does focus interact with tabs and splits?
The text was updated successfully, but these errors were encountered: