Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings and Errors don't appear upon hover #75304

Closed
lramos15 opened this issue Jun 11, 2019 · 3 comments
Closed

Warnings and Errors don't appear upon hover #75304

lramos15 opened this issue Jun 11, 2019 · 3 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2019

Comments

@lramos15
Copy link
Member

Issue Type: Bug

While developing in the VS Code repo the warning and errors do not appear on hover. The tooltips do appear on smaller repositories.

Steps to reproduce

  1. Create an error in the VS Code Repo
  2. Hover over the the error

The developer console contains an error for Maximum call stack size exceeded with this statement repeated:

    at _toDispose.forEach.e (lifecycle.ts:105)
    at Set.forEach (<anonymous>)
    at a.clear (lifecycle.ts:105)
    at a.dispose (lifecycle.ts:98)

VS Code version: Code - Insiders 1.36.0-insider (7bc29bf, 2019-06-11T08:29:28.099Z)
OS version: Darwin x64 18.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 3, 2, 2
Memory (System) 32.00GB (0.63GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (11)
Extension Author (truncated) Version
vscode-eslint dba 1.9.0
remote-containers ms- 0.60.0
remote-ssh-edit-nightly ms- 2019.6.15380
remote-ssh-explorer-nightly ms- 2019.6.15380
remote-ssh-nightly ms- 2019.6.15380
vscode-typescript-tslint-plugin ms- 1.1.0
debugger-for-chrome msj 4.11.3
vscode-docker Pet 0.6.2
material-icon-theme PKi 3.8.0
polacode pnp 0.3.2
vscode-sort-json ric 1.13.0
@lramos15
Copy link
Member Author

Upon reload hover will appear and then close instantaneously and I get the error Grammar is in an endless loop - Grammar pushed & popped a rule without advancing.

mjbvz added a commit to mjbvz/vscode that referenced this issue Jun 11, 2019
@mjbvz
Prevent dispose cycles
9c14fec 
For microsoft#75304

Make sure we do not get into a loop of tyring to dispose of an object by checking `isDisposed` before calling into dispose again

Also log if you try to register a disposeable on itself
@mjbvz mjbvz added this to the June 2019 milestone Jun 11, 2019
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jun 11, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 12, 2019

Can you please test this again in the latest insiders. I wasn't able to repo but fixed a potential cause of the issue

@mjbvz mjbvz closed this as completed Jun 14, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 14, 2019

Closing as dispose loop was fixed

@lramos15 lramos15 added the verified Verification succeeded label Jun 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2019
Development

No branches or pull requests
2 participants
@lramos15 @mjbvz