Terminal dom renderer doesn't render dimmed colors

[timsuchanek]

• VSCode Version: Version 1.35.1 (1.35.1)
• OS Version: macOS 10.13.6

Steps to Reproduce:

1. Open terminal in VSCode and run npx dim-cli - it prints Hello World with World dimmed
2. Change the "Integrated: Renderer Type" to dom - World is no longer dimmed.

Canvas Renderer

Dom Renderer

Does this issue occur when all extensions are disabled?: Yes

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Rendering issues in a new terminal when using dom renderer mode (#74507)

[Tyriar]

This is already done, we just need to update a css file.

To verify:

echo -e 'abc\x1b[2mdef'

[alexr00]

@Tyriar is this intended to be non-Windows only? I have verified on Ubuntu, but the dimming never works on Windows in the integrated terminal.

[Tyriar]

@alexr00 it's easier to test these on non-Windows as support can depend on the shell and the pty backend. Normally you can test these types of issues on conpty and wsl but things can still possibly go wrong (for example conpty doesn't print black background correctly).