Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Telemetry Command Build Process #76113

Closed
2 tasks done
lramos15 opened this issue Jun 25, 2019 · 2 comments
Closed
2 tasks done

Improve Telemetry Command Build Process #76113

lramos15 opened this issue Jun 25, 2019 · 2 comments
Assignees
Labels
vscode-build VS Code build process issues
Milestone

Comments

@lramos15
Copy link
Member

lramos15 commented Jun 25, 2019

Follow up from #76029 about ways to improve the build process for how we ship JSON with the telemetry command.

  • Git clone off a specific commit
  • Move telemetry*.json out of the src directory and into the root.
@lramos15 lramos15 self-assigned this Jun 25, 2019
@lramos15 lramos15 added the debt Code quality issues label Jun 25, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Jun 26, 2019

@lramos15 I'd feel much better if we either do it this iteration (today or tomorrow) or revert the PR altogether.

@joaomoreno joaomoreno removed the debt Code quality issues label Jun 26, 2019
@joaomoreno joaomoreno added this to the June 2019 milestone Jun 26, 2019
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug vscode-build VS Code build process issues labels Jun 26, 2019
@lramos15
Copy link
Member Author

I'll see if I can get it fixed in time. The feature itself seems to be working, just the build needs improvements which almost feels iteration independent. I'll see what I can do 👍

@joaomoreno joaomoreno removed the bug Issue identified by VS Code Team member as probable bug label Jun 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vscode-build VS Code build process issues
Projects
None yet
Development

No branches or pull requests

2 participants