Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Telemetry Extractor Build #76196

Merged
merged 14 commits into from
Jun 27, 2019

Conversation

lramos15
Copy link
Member

Changes as discussed in #76029 and #76113.
I currently have just hardcoded the commit id into the scripts to allow reproducibility until we release an NPM package as I was advised by @sbatten and @Tyriar that it wouldn't be worth the effort to implement something similar to Distro's commit checkout process.

@lramos15 lramos15 requested a review from joaomoreno June 26, 2019 18:19
@lramos15 lramos15 self-assigned this Jun 26, 2019
@lramos15 lramos15 added the vscode-build VS Code build process issues label Jun 26, 2019
@lramos15 lramos15 requested review from sbatten and Tyriar June 26, 2019 18:22
@Tyriar Tyriar removed their request for review June 26, 2019 23:55
@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Jun 27, 2019
@joaomoreno joaomoreno added this to the June 2019 milestone Jun 27, 2019
@joaomoreno
Copy link
Member

@lramos15 Good job!

I've pushed the following changes before merging this in:

  • Extractor module
    • Add typescript as a dev dependency
    • Add tsc as a postinstall script
    • Make the created JSON objects be compact instead of formatted with 4 spaces indentation
  • Build
    • Clone the tool repo to a better place: $BUILD_STAGINGDIRECTORY
    • Move the built files to a better place: .build/telemetry

@joaomoreno joaomoreno merged commit 1bdbb8f into master Jun 27, 2019
@joaomoreno joaomoreno deleted the lramos15/telemetry-build-improvements branch June 27, 2019 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. vscode-build VS Code build process issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants