Disabled line numbers reappear after toggling Zen mode

[abbioro]

• VSCode Version: 1.36.1
• OS Version: Windows_NT x64 6.1.7601

Steps to Reproduce:

1. Add the following to user config to disable line numbers in markdown files

"[markdown]": {
    "editor.lineNumbers": "off"
},

2. Open a markdown file, note that line numbers are disabled as expected
3. Activate Zen mode
4. Deactivate Zen mode
5. Line numbers reappear despite being disabled for markdown files in config

Note that this only happens if you disable line numbers for a specific mode. If line numbers are disabled globally everything works as expected and they never reappear.

Does this issue occur when all extensions are disabled?: Yes

[isidorn]

Thanks for reporting this. The next vscode insiders will have the fix so you can try it out there.

[crystalfp]

The problem persists in 1.37.1

[isidorn]

@crystalfp this will only be fixed in the next release, not in 1.37.1
But in 1.38.
It is available currently in vscode insiders so you can use that in the meantime. Thanks

[mjbvz]

I was still able to repo this in 8cd00a7 by adding the setting as a workspace setting

[isidorn]

@mjbvz I can not reproduce this with a fresh user data dir on latest insiders.
Please let me know what you are doing differently than me and I will reopen.

[jrieken]

Yeah, reproduces with @mjbvz's steps. @isidorn You aren't following the steps from the OP, e.g the setting must be specific to markdown (and a workspace setting)

[isidorn]

@jrieken @mattbierner thanks for catching this. Pushing to next milestone.
@sandy081 how can I get the true value of the configuration setting. Currently I am using

this.configurationService.getValue('editor.lineNumbers', { resource: model.uri });

I thought this code snippet will also take care of workspace setting and respect markdown.

[crystalfp]

The workspace setting seems irrelevant. I have the setting specific to markdown (this is critical) at the user level and the problem is there.

[isidorn]

@crystalfp please read my comment from above #78545 (comment)
We are all using vscode insiders

[crystalfp]

Sorry. I tried only to be helpful...

[isidorn]

No problemo.

[jeanp413]

how can I get the true value of the configuration setting. Currently I am using

this.configurationService.getValue('editor.lineNumbers', { resource: model.uri });

I thought this code snippet will also take care of workspace setting and respect markdown.

The overrideIdentifier property is also needed

this.configurationService.getValue('editor.lineNumbers', { overrideIdentifier: model.getModeId(), resource: model.uri });

[sandy081]

@jeanp413 Thanks for pitching in. You are correct overrideIdentifier is needed to get language overridden settings.

Instead you can use the following service which takes care of overrideIdentifier and resource for you.

https://github.com/microsoft/vscode/blob/cd46e5b/src/vs/editor/common/services/resourceConfiguration.ts#L32

[isidorn]

@jeanp413 @sandy081 thanks. I decided to go with the overrideIdentifier since I did not want to introduce a new service dependency on that layer.