Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show CSS deprecated property with CompletionItem#deprecated #79584

Closed
octref opened this issue Aug 21, 2019 · 6 comments
Closed

Show CSS deprecated property with CompletionItem#deprecated #79584

octref opened this issue Aug 21, 2019 · 6 comments
Assignees
@octref
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality verified Verification succeeded
Milestone
August 2019

Comments

@octref
Copy link
Contributor

octref commented Aug 21, 2019

Ref API: #50972

image
@octref octref self-assigned this Aug 21, 2019
@octref octref added this to the August 2019 milestone Aug 21, 2019
@octref octref added css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality labels Aug 21, 2019
octref added a commit to microsoft/vscode-css-languageservice that referenced this issue Aug 22, 2019
@octref
Show deprecated completion item for microsoft/vscode#79584
8ded84c
@octref
Copy link
Contributor Author

octref commented Aug 22, 2019 •
edited
Loading

@jrieken I have a branch in CSS LS that does this. Will wait for the proposal in #23927 to finalize.

Hard to glance through the list and see which ones are deprecated though.

image

@jrieken
Copy link
Member

jrieken commented Aug 22, 2019

👏 looking already good. I agree that the UX needs some more tweaking. Maybe we can make dim deprecated items a little or change the style of strikeout

octref added a commit to microsoft/vscode-css-languageservice that referenced this issue Aug 26, 2019
@octref
Show deprecated completion item for microsoft/vscode#79584
a7d3146
octref added a commit that referenced this issue Aug 26, 2019
@octref
Add middleware for processing deprecated. Fix #79584
faec415
@octref
Copy link
Contributor Author

octref commented Aug 26, 2019

Looking much nicer now:

image

@dbaeumer Is there an easier way to do this, or is the only way to adopt this without getting new version of LS library adding a client side middleware? faec415

I observe that if Language Server returns CompletionItem with deprecated, it'll not be stripped on client side's ProtocolCompletionItem. If it returns with CompletionItem with tags, tags will be stripped.

@dbaeumer
Copy link
Member

@octref currently not: reason being is that in LSP land I only adapt API if it is release in a stable build. I am not depending on insider build version in the LSP library. So more official support has to wait until beginning of September.

octref added a commit to microsoft/vscode-css-languageservice that referenced this issue Aug 28, 2019
@octref
Show deprecated completion item for microsoft/vscode#79584
243d7e1
@octref octref mentioned this issue Aug 28, 2019
Merged
@octref octref closed this as completed in 2103028 Aug 28, 2019
octref added a commit that referenced this issue Aug 28, 2019
@octref
Merge pull request #79962 from microsoft/pine/css-deprecated
eeab6fc 
Add middleware for processing deprecated. Fix #79584
@octref octref mentioned this issue Aug 28, 2019
Closed
@octref octref added the verification-needed Verification of issue is requested label Aug 28, 2019
@aeschli
Copy link
Contributor

aeschli commented Aug 28, 2019

verified in
Version: 1.38.0-insider
Commit: eeab6fc
Date: 2019-08-28T05:34:09.557Z
Electron: 4.2.9
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 4.15.0-58-generic

@aeschli aeschli added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Aug 28, 2019
hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
@octref @hwhung0111
Add middleware for processing deprecated. Fix microsoft#79584
dfc8936
@LasseRosenow
Copy link

LasseRosenow commented Sep 5, 2019 •
edited
Loading

It would be cool if we could also have this feature in the editor and not only in auto-complete.

So that grid-gap: 5px; gets a yellow underline as a warning and maybe also a "quick fix" action?

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
5 participants
@jrieken @dbaeumer @octref @aeschli @LasseRosenow