Various octicons are incorrect

[anthonydresser]

Issue Type: Bug

A number of the octicons are incorrect in the insiders build.

person-filled:

organization-filled:

Not sure if these are the only ones.

VS Code version: Code - Insiders 1.38.0-insider (0f73473, 2019-08-23T05:39:22.818Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	63.92GB (36.93GB free)
Process Argv
Screen Reader	no
VM	0%

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Update Octicons to match new icon style (#76909)

[isidorn]

Since this has a bug label, removing verification-needed which is only for features.
WHile I am here what are the steps to verify? Where do we actually use those icons?

[miguelsolorio]

Verification steps:

1. Ensure that you have workbench.octiconsUpdate.enabled set to false
2. Contribute a status bar item that utilizes the $(person-filled) and $(organization-filled) icons (you can use my test extension and modify the extension.ts file)
3. See that the icons match what is on Stable:
   

EDIT: Also verify that the $(smiley) icon is filled and not an outline:

[isidorn]

Hmm I get this. WHich I think are just updated icons -> verified

[miguelsolorio]

Those are the new Octicons and are not enabled by default, ensure that you have workbench.octiconsUpdate.enabled set to false. Also, it appears that the new Octicons are overriding the old ones, so I just pushed a fix (via e594b18) to scope all new Octicons only when the setting is enabled. Please use the same verification steps from above and ensure the icons match Stable as shown in the screenshot.

[isidorn]

Yeah with that setting I get good icons