Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing all editors: move dirty editor to the front when asking to confirm #79787

Closed
bpasero opened this issue Aug 26, 2019 · 0 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Closing all editors: move dirty editor to the front when asking to confirm #79787

bpasero opened this issue Aug 26, 2019 · 0 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
@bpasero
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Milestone
August 2019

Comments

@bpasero
Copy link
Member

bpasero commented Aug 26, 2019

Steps to Reproduce:

  1. open multiple editors across multiple groups
  2. make some of them dirty across multiple groups
  3. click "Close All" action from "Open Editors" view

=> it would be good if the first dirty editor in each group is being revealed so that the user can review the changes before making a choice. We do the same when closing all editors in a single group.

=> today we just ask in a single dialog for all files (which is intentional) but we do not show the dirty files in each group
@bpasero bpasero added feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window labels Aug 26, 2019
@bpasero bpasero added this to the August 2019 milestone Aug 26, 2019
@bpasero bpasero self-assigned this Aug 26, 2019
@bpasero bpasero added the verification-needed Verification of issue is requested label Aug 26, 2019
@isidorn isidorn added the verified Verification succeeded label Aug 27, 2019
hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
@bpasero @hwhung0111
fix microsoft#79763 (also fixes microsoft#79787)
8982fe8
@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
August 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
2 participants
@bpasero @isidorn