Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch Smoke test fails #79867

Closed
dbaeumer opened this issue Aug 27, 2019 · 6 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Launch Smoke test fails #79867

dbaeumer opened this issue Aug 27, 2019 · 6 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
Labels
smoke-test-failure verified Verification succeeded
Milestone

Comments

@dbaeumer
Copy link
Member

Testing #79731

Happens for Insider and Electron 6 exploration

 Launch
** Timeout!
Error: Active element not found. Current active element is 'HTML > BODY.windows.file-icons-enabled.vs-dark.vscode-theme-defaults-themes-dark_plus-json > DIV.monaco-workbench.windows.nopanel > DIV.monaco-grid-view > DIV.monaco-grid-branch-node > DIV.monaco-split-view2.vertical > DIV.split-view-container > DIV.split-view-view.visible > DIV.monaco-grid-branch-node > DIV.monaco-split-view2.horizontal > DIV.split-view-container > DIV.split-view-view.visible > DIV.monaco-grid-branch-node > DIV.monaco-split-view2.vertical > DIV.split-view-container > DIV.split-view-view.visible > DIV#workbench.parts.editor.part.editor.has-watermark > DIV.content > DIV.grid-view-container > DIV.monaco-grid-view > DIV.monaco-grid-branch-node > DIV.monaco-split-view2.vertical.separator-border > DIV.split-view-container > DIV.split-view-view.visible > DIV.editor-group-container.active > DIV.editor-container > DIV.editor-instance > DIV.monaco-scrollable-element > DIV'. Looking for .editor-instance[id="workbench.editor.walkThroughPart"] > div > div[tabIndex="0"]
    at g.<anonymous> (file:///C:/Users/dirkb/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1212:821)
    at Generator.next (<anonymous>)
    at file:///C:/Users/dirkb/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:35:566
    at new Promise (<anonymous>)
    at n (file:///C:/Users/dirkb/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:35:343)
    at g.isActiveElement (file:///C:/Users/dirkb/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1212:513)
    at l.call (file:///C:/Users/dirkb/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1217:653)
    at C.onPromise (file:///C:/Users/dirkb/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:339:361)
    at C.onRawMessage (file:///C:/Users/dirkb/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:338:1012)
    at C.protocolListener.protocol.onMessage.e (file:///C:/Users/dirkb/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:338:531)
    at d.fire (file:///C:/Users/dirkb/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:107:468)
    at EventEmitter.n (file:///C:/Users/dirkb/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:104:788)
    at EventEmitter.emit (events.js:182:13)
    3) verifies that application launches when user data directory has non-ascii characters

and

 1) Running Code                                                                                                                                                   
      "before all" hook:                                                                                                                                           
    Error: Timeout: is active element '.editor-instance[id="workbench.editor.walkThroughPart"] > div > div[tabIndex="0"]' after 20 seconds.                        
     at C:\Users\dirkb\Projects\mseng\VSCode\vscode\test\smoke\out\vscode\code.js:175:23                                                                           
     at Generator.next (<anonymous>)                                                                                                                               
     at fulfilled (out\vscode\code.js:8:58)                                                                                                                        
                                                                                                                                                                   
 2) Running Code                                                                                                                                                   
      "after all" hook:                                                                                                                                            
    TypeError: Cannot read property 'stop' of undefined                                                                                                            
     at Context.<anonymous> (out\main.js:242:28)                                                                                                                   
     at Generator.next (<anonymous>)                                                                                                                               
     at C:\Users\dirkb\Projects\mseng\VSCode\vscode\test\smoke\out\main.js:11:71                                                                                   
     at new Promise (<anonymous>)                                                                                                                                  
     at __awaiter (out\main.js:7:12)                                                                                                                               
     at Context.<anonymous> (out\main.js:241:16)                                                                                                                   
                                                                                                                                                                   
 3) Launch                                                                                                                                                         
      verifies that application launches when user data directory has non-ascii characters:                                                                        
    Error: Timeout: is active element '.editor-instance[id="workbench.editor.walkThroughPart"] > div > div[tabIndex="0"]' after 20 seconds.                        
     at C:\Users\dirkb\Projects\mseng\VSCode\vscode\test\smoke\out\vscode\code.js:175:23                                                                           
     at Generator.next (<anonymous>)                                                                                                                               
     at fulfilled (out\vscode\code.js:8:58)                                                                                                                        
                                                                                                                                                                   
 4) "after all" hook:                                                                                                                                              
    Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.                          
                                                                                                                                                                   
                                                                                                                                                                   
                                                                                                                                                                   
                                                                                                                                                                   
@isidorn
Copy link
Contributor

isidorn commented Aug 27, 2019

It seems like the smoke test is not updated to the new grid-view (looking at the errors). Thus forwarding this to @sbatten
also fyi @deepak1556 as the author of the testplan

@isidorn isidorn assigned sbatten and unassigned isidorn Aug 27, 2019
@sbatten sbatten assigned isidorn and unassigned sbatten Aug 27, 2019
@sbatten
Copy link
Member

sbatten commented Aug 27, 2019

@isidorn this fails with or without grid layout setting. The verification seems broken because the active element in the output above matches the active element being searched for.

@isidorn
Copy link
Contributor

isidorn commented Aug 28, 2019

It seems like the app does not get properly intiailized here

Feels like some electron update caused this

@isidorn isidorn added this to the August 2019 milestone Aug 28, 2019
@dbaeumer
Copy link
Member Author

I also saw this testing current insider.

@joaomoreno
Copy link
Member

joaomoreno commented Aug 28, 2019

@dbaeumer @sbatten @isidorn The error says:

    Error: Timeout: is active element '.editor-instance[id="workbench.editor.walkThroughPart"] > div > div[tabIndex="0"]' after 20 seconds.                        

So, it can't find that element in the DOM when the Walkthrough page is showing. I just tried that on dev and the test is indeed correct to fail:

screenshot QbgQIM

Started breaking since fc4fd26 cc @bpasero

@bpasero
Copy link
Member

bpasero commented Aug 28, 2019

AH yeah, thanks!

@dbaeumer dbaeumer added the verified Verification succeeded label Aug 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smoke-test-failure verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants