Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong hover on machine-scoped settings #79977

Closed
aeschli opened this issue Aug 28, 2019 · 3 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Wrong hover on machine-scoped settings #79977

aeschli opened this issue Aug 28, 2019 · 3 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
Labels
config VS Code configuration, set up issues polish Cleanup and polish issue
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 28, 2019

Verifying #73985 (comment)

php.validate.executablePath has the machinescope.

On a remote window, open the workspace settings and paste
"php.validate.executablePath": "asdad"

Hover should say that it can only be applied in 'machine' settings.

image

@aeschli
Copy link
Contributor Author

aeschli commented Aug 28, 2019

In a remote window, the setting can also be configured in a user settings (by adding it to the settings.json editor, no error hover)
#73985 (comment) says it should only be allowed in machine settings, so not sure what's the expected behaviour.

@sandy081
Copy link
Member

@aeschli

In a remote window, the setting can also be configured in a user settings (by adding it to the settings.json editor, no error hover)

This is correct. Updated the comment.
A machine setting can be configured only at machine level (local or remote).

@sandy081 sandy081 added config VS Code configuration, set up issues polish Cleanup and polish issue labels Aug 28, 2019
@sandy081 sandy081 added this to the August 2019 milestone Aug 28, 2019
@sandy081
Copy link
Member

Hover should say that it can only be applied in 'machine' settings.

Since we do not surface machine settings in UI, I would rephrase as follows

This setting can only be applied in user settings in local window or in remote settings in remote window.

hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
config VS Code configuration, set up issues polish Cleanup and polish issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants