Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing "Close" panel button to be "Hide" #8018

Closed
Tyriar opened this issue Jun 22, 2016 · 3 comments
Closed

Consider changing "Close" panel button to be "Hide" #8018

Tyriar opened this issue Jun 22, 2016 · 3 comments
Assignees
Labels
ux User experience issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 22, 2016

Currently all panels feature a x button which when hovered say "Close". This is ambiguous for the terminal as to weather it will destroy the processes and potentially will be for other/future panels. I suggest changing this to a minimize/hide icon - with a tooltip that reads "Hide".

image

/cc @bgashler1 @bpasero @stevencl

@Tyriar Tyriar added ux User experience issues workbench labels Jun 22, 2016
@dbaeumer
Copy link
Member

Assigning to @bgashler1 since this is a overall UI issue

@bgashler1
Copy link
Contributor

bgashler1 commented Jun 24, 2016

After discussing this with others and thinking about it, I feel it's best we use a downward chevron arrow (collapse arrow).

This implies a non-destructive removal of a view and disambiguates the expected behavior some users have of an "X" in a terminal (terminating a process, removing history and closing the terminal).

screen shot 2016-06-23 at 7 29 20 pm

@Tyriar
Copy link
Member Author

Tyriar commented Jun 24, 2016

I'll leave the "Close" tooltip as is to keep it consistent with the command name

Tyriar added a commit that referenced this issue Jun 24, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ux User experience issues
Projects
None yet
Development

No branches or pull requests

3 participants