Peek Definition + ENTER doesn' go to definition anymore

[0ldF0x]

Issue Type: Bug

How do you go to definition from peek definition window?
Before the 1.38.0 update you simply pressed enter in "peek definition" (ALT+12) and it jumped to definition. After the update this doesn't work anymore?

VS Code version: Code 1.38.0 (3db7e09, 2019-09-03T21:49:13.459Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3592)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.91GB (7.74GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (4)

Extension	Author (truncated)	Version
Bookmarks	ale	10.5.0
python	ms-	2019.9.34474
text-marker	ryu	1.11.0
plsql-language	xyz	1.8.2

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Peek Definition menu option missing in the "Peek Definition" window (#27128)
• peek definition not closed (#46065)
• Go to definition (#75978)
• Go to definition (#75977)
• Peek definition works like Go to Definition if it runing from command palette (#20952)

[jrieken]

@bpasero @joaomoreno Did anything change in the tree or the workbrench tree? It seems that the item that got initially focus cannot be selected with Enter anymore

[joaomoreno]

The item already is both focused and selected, so pressing Enter won't fire a selection change event since the selection doesn't change (that was a tree change from some months ago, so it explains why this broke).

I copied the same if statement which is located 10 lines above. Right now both events are being listened to, I believe for your use case we can simply drop the selection change and simply listen to the open event.

[jrieken]

Hm, the weird thing is that it works in 1.37

[joaomoreno]

Yeah that's pretty weird. 🤔

[chapeupreto]

Yeah! I can confirm it doesn't work after latest updates:

Version: 1.38.1
Commit: b37e54c
Date: 2019-09-11T13:31:32.854Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.7.0

[ghost]

Until the fix is available, pressing Shift + down arrow instead of Enter can be used as workaround.

[jrieken]

Until the fix is available, pressing Shift + down arrow instead of Enter can be used as workaround.

Much better: there is VS Code Insider (https://code.visualstudio.com/insiders/) which updated daily and which has fix for this since 29 days