Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font stylistic set support #80577

Closed
smlombardi opened this issue Sep 9, 2019 · 2 comments
Closed

Font stylistic set support #80577

smlombardi opened this issue Sep 9, 2019 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality font-rendering Font rendering issues

Comments

@smlombardi
Copy link

Issue Type: Feature Request

In the new version 2.0 of Fira Code, there are some stylistic options that can be set (e.g. old-style figures). In Sublime Text there's a simple json key you can add to its settings file to enable the ones you want.

In VSCode, you have to use an extension which modifies the "custom css". This seems hacky and needs to be enabled after every update.

I'd rather be able to do this with a settings key like Sublime Text.

VS Code version: Code - Insiders 1.39.0-insider (0f1bd77, 2019-09-09T05:26:48.181Z)
OS version: Darwin x64 18.7.0

@alexdima alexdima added editor-rendering Editor rendering issues feature-request Request for new features or functionality labels Sep 10, 2019
@alexdima
Copy link
Member

Implemented via ab0eb6d (#82153) and it already shipped in Insiders.

e.g.

"editor.fontLigatures": "'ss01', 'ss02', 'ss03', 'ss04', 'ss05', 'ss06', 'zero', 'onum'"

or

    "editor.fontFamily": "Fira Code"    
    "editor.fontLigatures": true,
    "[cpp]": {
        "editor.fontLigatures": "'ss06', 'ss19'",
    },
    "[javascript]": {
        "editor.fontLigatures": "'ss06'",
    }, 

@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 25, 2019
@alexdima alexdima added this to the October 2019 milestone Oct 25, 2019
@alexdima alexdima added font-rendering Font rendering issues and removed editor-rendering Editor rendering issues labels Oct 25, 2019
@chrmarti chrmarti removed this from the October 2019 milestone Oct 29, 2019
@arrowtype
Copy link

Hey @alexandrudima, awesome work on this – it makes my code font project so much nicer to use in VS Code, and is yet another reason I'm really happy to be using VS Code as my go-to editor. :) Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality font-rendering Font rendering issues
Projects
None yet
Development

No branches or pull requests

4 participants