Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Port CSS "font-feature-settings" in settings.json #82153

Closed
qrqiuren opened this issue Oct 9, 2019 · 3 comments
Closed

[Feature Request] Port CSS "font-feature-settings" in settings.json #82153

qrqiuren opened this issue Oct 9, 2019 · 3 comments
Assignees
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality font-rendering Font rendering issues verified Verification succeeded
Milestone

Comments

@qrqiuren
Copy link

qrqiuren commented Oct 9, 2019

See the instructions of enabling Fira Code's stylistic sets in editors.

In VS Code, we have to hack the editor to override CSS's font-feature-settings to change the stylistic sets. I hope we can configure this option directly in settings.json.

@alexdima alexdima added feature-request Request for new features or functionality font-rendering Font rendering issues editor-rendering Editor rendering issues labels Oct 9, 2019
@alexdima alexdima added this to the Backlog milestone Oct 9, 2019
@alexdima
Copy link
Member

alexdima commented Oct 9, 2019

It will be possible to define via e.g.:

"editor.fontLigatures": "'ss01', 'ss02', 'ss03', 'ss04', 'ss05', 'ss06', 'zero', 'onum'"

@alexdima alexdima modified the milestones: Backlog, October 2019 Oct 9, 2019
@alexdima alexdima added the verification-needed Verification of issue is requested label Oct 28, 2019
@connor4312 connor4312 added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Oct 29, 2019
@wboka
Copy link

wboka commented Nov 15, 2019

UPDATE (2019-11-18): Solved in #84917 (comment)

This doesn't seem to work in VS Code v1.40.0 and v1.40.1. See #84917.

Has anyone had any luck getting this to work?

A few people on #84917 have been able to get the following code snippet to work but not the ssxx notation.

{
  // Code omitted for brevity
  "editor.fontLigatures": "'zero', 'onum'"
}

Versions

  • OS: Windows 10, 64-bit
  • VS Code: v1.40 and v1.40.1
  • Fira Code: 2.0

@alexdima
Copy link
Member

Resolved in #84917 (comment)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality font-rendering Font rendering issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants