-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Protection Improvements #80595
Comments
@jrieken In Redmond we discussed how we can improve the link protection configuring experience, but we realize QuickInput is not the right widget for all CRUD operations. So I went with the approach of having a FS provider and let use configure the JSON setting. I see #10547 and @Tyriar is interested in having something similar for editing an in-memory item in terminal area. I'm wondering if we should have a dedicated schema for such use cases. |
@octref Why is the list of trusted domains done is a separate (virtual) resource and not part of the (user) settings? |
Can you describe what is there to verify (I have the feeling this would even deserve it's own test item...) |
@aeschli because an extension could just write the settings and bypass the security feature completely. |
@octref how is this to be handled in an enterprise scenario? e.g. like when an engineering services team wants to create a one-click setup for a development environment, which consists of a couple of extensions pointing users to a bunch of external sites? Currently there is no way but to ask each developer to configure those domains. |
@samrat-gavale I opened #82794 but I don't have a plan yet. If you have a good suggestion how this might work, please follow up in that thread. |
The text was updated successfully, but these errors were encountered: