-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thin font rendering issues on macOS Catalina #82109
Comments
(Experimental duplicate detection) |
Noticed that in the code editor, the characters are also too thin, plus they are too far away from each other. This seems to be related to the macOS Catalina font kerning bug in Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1005969 |
@deepak1556 maybe something to backport |
One of my computers I downgraded to macOS Mojave because of this issue. On the other computer, downgrading is not possible (because of my photo library etc.), but I've found a workaround at least for the code editor: You can play around with the setting "Editor: Letter Spacing". On my computer, entering "-0.2" did a good job at working around this issue (at least for the editor, which is the most important to me). |
Try this in Terminal:
and reopen VS Code |
Thank you, but doesn't change anything and doesn't seem to have anything to do with this issue. (I had CGFontRenderingFontSmoothingDisabled to NO set globally before, that's probably the reason I don't see any change). |
Setting
Text looks better now but not as perfect as before on Mojave. |
Back in Mojave, this fix used to work fine but it doesn't anymore. Is there any other possible solution to this issue? |
I have have issue with font smoothing (MacBook Air 2017 )command which stopped working after Catalina update, so font looks kinda blurry. please give me solution for this. |
@MariuzM |
I've downloaded macOS version. No changes on iMac (Retina 5K, 27-inch, Late 2015), Catalina 10.15.1. Still thin fonts.
My VS Code settings (before):
So I have to set:
|
I think what we should keep in mind is that macOS has thinner fonts since Mojave, as wanted by Apple. The following workaround (or setting to get Pre-Mojave Font Rendering) works with Pre-Electron 6 versions (<= vscode 1.39), but not with >= 1.40: defaults write -g CGFontRenderingFontSmoothingDisabled -bool NO
defaults write com.microsoft.VSCode.helper CGFontRenderingFontSmoothingDisabled -bool NO For all users who don't use this workaround, font rendering has improved since 1.40, for all those who use it it has stayed the same or even deteriorated. So I think many users see the thinner fonts as a bug even though this is not one at all. PS: defaults delete -g CGFontRenderingFontSmoothingDisabled
defaults delete com.microsoft.VSCode.helper CGFontRenderingFontSmoothingDisabled |
I wonder if this issue is reproducible when running VSCode in a browser. We allow to run VSCode in a very simplified form in a browser following these steps:
If you are not able to set this up, we also provide a hosted version of VSCode for Web at: https://vscode-web-test-playground.azurewebsites.net Does the issue reproduce in that setup in the browser? |
So the way I understand this Mojave font tweak is not causing the issue. |
@MariuzM very strange, for me its the exact opposite, besides the dimmed colorization. Can you check the Settings -> Workbench -> Appearance -> Font Aliasing, is it set to |
Yep on all instances it's set to default |
MacOS Preferences -> General -> Use font smoothing when available (x). Do you also have this enabled? For me, when i disable this option i get the same results as you. |
Tried both on and off no difference this was tested with default Mojave (no font tweak) |
The Chromium team has yet to fix this unfortunately. Until then, I guess there's not much that can be done on the VS Code side. I have downgraded my main computer to macOS Mojave because of this issue. https://bugs.chromium.org/p/chromium/issues/detail?id=1005969 "We're treating this issue as high priority and progress is being made towards a fix. The issue is complex due to changes to the "San Francisco" system font and how CoreText works with respect to setting the optical size axis. As you can see from the BlockedOn: column, the Chromium side fix depends on fixes in the Skia graphics library. Please continue to star this issue and follow along, but please keep comments on topic." |
They have patch to fix it, can't wait to update it. Thanks guys |
Is this still an ongoing issue? |
As for me, it should be closed. Thanks! |
For me it's still an issue but i just got used to it. |
This won't get fixed i believe, VSCode or Electron stoped using MacOS sub pixel AA, even on Mojave and later Apple stoped supporting this |
The Chromium team has (partially) fixed the narrow font issue and shipped it in the Canary channel (v81). The current stable Electron release depends on Chromium 80 https://github.com/electron/electron/releases/tag/v8.0.0 The VSCode project depends on Electron 7.1.11 at the moment Line 97 in f4a868f
So there seems still a long way to go. |
the relevant chromium fix has been landed with our latest stable, closing |
Issue Type: Bug
After upgrading to macOS Catalina, the system font used in Visual Studio Code looks very narrow - and different from other apps in macOS Catalina.
It seems that instead of using SF Pro Text, Visual Studio Code uses .SF NS on macOS Catalina.
This is probably due to a bug in Chromium which I have reported here: https://bugs.chromium.org/p/chromium/issues/detail?id=1012247
VS Code version: Code 1.38.1 (b37e54c, 2019-09-11T13:31:32.854Z)
OS version: Darwin x64 19.0.0
System Info
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
The text was updated successfully, but these errors were encountered: