Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: extensionKind can be an array #83500

Closed
2 tasks done
alexdima opened this issue Oct 29, 2019 · 1 comment
Closed
2 tasks done

Test: extensionKind can be an array #83500

alexdima opened this issue Oct 29, 2019 · 1 comment

Comments

@alexdima
Copy link
Member

alexdima commented Oct 29, 2019

Test plan item for #83511

Complexity: 3

It is now possible to define extensionKind as an array. This can be defined in the following places:

  • extension's manifest (package.json)
  • user settings (remote.extensionKind)
  • product.json

For example, if defined as ["ui", "workspace"] this indicates that the extension can run both on the ui and the workspace side, with a preference for running on the ui side, so if the extension is installed on both places, the ui side will win. If an extension uses an empty array, it means that the extension does not support remote scenarios.

Please test:

  • create or edit an existing extension and tweak in all kind of ways the extensionKind and check that it works as expected.
  • NOTE: for 1 milestone, for compatibility reasons, we will interpret an extensionKind of "ui" as ["ui", "workspace"], so if an extension is marked with "ui" it can execute on both sides, with preference given to the local side
@aeschli
Copy link
Contributor

aeschli commented Oct 30, 2019

Verified all 3 definition places. All looks good.

@aeschli aeschli removed their assignment Oct 30, 2019
@kieferrm kieferrm removed their assignment Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants