Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extensionKind to be an array #83511

Closed
alexdima opened this issue Oct 29, 2019 · 1 comment
Closed

Support extensionKind to be an array #83511

alexdima opened this issue Oct 29, 2019 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality on-testplan plan-item VS Code - planned item for upcoming
Milestone

Comments

@alexdima
Copy link
Member

Some extensions can execute only on the ui side, some can execute only on the workspace side, while some can execute in both places and might prefer one over the other.

After discussions, we have come to the conclusion that the best way forward is to support that extensions can define extensionKind as an array. e.g.

  • extensionKind: ["ui", "workspace"] would define that an extension can run on both sides, with a preference to running on the ui side if possible (if it is installed on the ui side)
  • extensionKind: "ui" would define that an extension can only run on the ui side.

Since we need to first have one stable release out before extensions can adopt the new array format, we will maintain for a brief period that extensionKind: "ui" is treated as extensionKind: ["ui", "workspace"] in order to get compatibility and give enough time for extensions to adopt.

FYI @egamma @sandy081

@alexdima alexdima added the plan-item VS Code - planned item for upcoming label Oct 29, 2019
@alexdima alexdima self-assigned this Oct 29, 2019
@alexdima alexdima added this to the October 2019 milestone Oct 29, 2019
@alexdima alexdima added the feature-request Request for new features or functionality label Oct 29, 2019
@alexdima
Copy link
Member Author

Implemented via c6f4d5c

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests

1 participant