Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for emmet commands #8454

Closed
Tyriar opened this issue Jun 28, 2016 · 3 comments
Closed

Add tests for emmet commands #8454

Tyriar opened this issue Jun 28, 2016 · 3 comments
Assignees
@ramya-rao-a
Labels
debt Code quality issues emmet Emmet related issues
Milestone
July 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 28, 2016

#8207

  • VSCode Version: Code - Insiders 1.3.0-insider (d0c2b89, 2016-06-28T05:01:27.563Z)
  • OS Version: Linux x64 4.4.0-24-generic, Ubuntu 16.04

Little excuse not to have tests here considering they should be really easy to write and potentially leverage an official test suite.
@egamma
Copy link
Member

egamma commented Jun 29, 2016

I agree that we should have tests for the emmet integration (EditorAccessor class) but not for emmet itself. Emmet is an upstream component and the testing belongs to the component.

@mjbvz mjbvz added debt Code quality issues emmet Emmet related issues labels Nov 11, 2016
@egamma egamma assigned ramya-rao-a and unassigned egamma Apr 20, 2017
@ramya-rao-a
Copy link
Contributor

Now that we have the new emmet model in the extension, I'll use this issue for adding tests to the emmet extension

@ramya-rao-a ramya-rao-a added this to the July 2017 milestone Jun 30, 2017
@kieferrm kieferrm mentioned this issue Jul 6, 2017
Closed
39 tasks
ramya-rao-a added a commit that referenced this issue Jul 21, 2017
@ramya-rao-a
First set of tests for Emmet commands #8454
e1f7580
ramya-rao-a added a commit that referenced this issue Jul 21, 2017
@ramya-rao-a
Test for Emmet Update Tag #8454
5ed9835
@ramya-rao-a
Copy link
Contributor

https://github.com/Microsoft/vscode/tree/master/extensions/emmet/src/test is the location of tests for all of the Emmet actions coming from the new emmet extension

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
debt Code quality issues emmet Emmet related issues
Projects
None yet
Milestone
July 2017
Development

No branches or pull requests
4 participants
@egamma @Tyriar @mjbvz @ramya-rao-a