Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Editor text rendering is using grayscale #84698

Closed
alexdima opened this issue Nov 13, 2019 · 2 comments
Closed

Code Editor text rendering is using grayscale #84698

alexdima opened this issue Nov 13, 2019 · 2 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority lcd-text-rendering verified Verification succeeded
Milestone
October 2019 Reco...

Comments

@alexdima
Copy link
Member

alexdima commented Nov 13, 2019 •
edited
Loading

  • open one or multiple editors on Windows
  • the text inside the editor is rendered with grayscale antialising
    image
  • it should use subpixel AA:
    image
@alexdima alexdima self-assigned this Nov 13, 2019
@alexdima alexdima added the candidate Issue identified as probable candidate for fixing in the next release label Nov 13, 2019
@alexdima alexdima added this to the October 2019 Recovery milestone Nov 13, 2019
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority lcd-text-rendering labels Nov 13, 2019
@alexdima alexdima mentioned this issue Nov 13, 2019
Closed
alexdima added a commit that referenced this issue Nov 13, 2019
@alexdima
Fixes #84698: Replace will-change: transform with `transform: trans…
b1fd260 
…late3d(0px, 0px, 0px)` to work around Chromium change
@alexdima alexdima mentioned this issue Nov 13, 2019
Merged
@Guema Guema mentioned this issue Nov 13, 2019
Closed
@mjbvz mjbvz closed this as completed Nov 13, 2019
@mjbvz mjbvz added the verified Verification succeeded label Nov 13, 2019
@nklmilojevic
Copy link

I just tried 1.40.1. This doesn't fix it on macOS Catalina.

1.39.2:

CleanShot 2019-11-13 at 22 37 21

1.40.1:

CleanShot 2019-11-13 at 22 37 29

@forivall
Copy link
Contributor

It did, however, fix the issue on Mojave (as I haven't updated to Catalina yet)

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority lcd-text-rendering verified Verification succeeded
Projects
None yet
Milestone
October 2019 Recovery
Development

No branches or pull requests
4 participants
@forivall @alexdima @nklmilojevic @mjbvz