Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html] Unquoted HTML attributes are parsed/displayed incorrectly #84729

Closed
Aloso opened this issue Nov 13, 2019 · 2 comments
Closed

[html] Unquoted HTML attributes are parsed/displayed incorrectly #84729

Aloso opened this issue Nov 13, 2019 · 2 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues verified Verification succeeded
Milestone
November 2019

Comments

@Aloso
Copy link

Aloso commented Nov 13, 2019

Bug:

Unquoted HTML attributes containing slashes (/) are parsed incorrectly:

  • If the attribute is an URL, only the part before the first slash is underlined and opened when following the link with Ctrl+Click.
  • When reformatting the document, indentation is buggy after the unquoted attribute

Steps to Reproduce:

  1. Open the following HTML document:

    <!DOCTYPE html>
<html>
<body>
    <a href=http://www.example.com></a>
</body>
</html>

    You should see the incorrect link underline.

  2. Reformat the document. It now looks like this:

    <!DOCTYPE html>
<html>

<body>
  <a href=http://www.example.com> </a> </body> </html>

VS Code version: VSCodium 1.40.0 (86405ea, 2019-11-07T19:55:05.094Z)
OS version: Linux x64 5.3.8-3-MANJARO

I also tested it in the latest insider version (1.41.0-1573628786)

System Info
Item Value
CPUs AMD A8-7600 Radeon R7, 10 Compute Cores 4C+6G (4 x 2152)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: unavailable_off
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 1, 1, 1
Memory (System) 14.58GB (1.78GB free)
Process Argv --unity-launch
Screen Reader no
VM 0%
Extensions (2)
Extension Author (truncated) Version
toml be5 0.4.0
ra-lsp mat 0.0.1
@aeschli aeschli added html HTML support issues bug Issue identified by VS Code Team member as probable bug labels Nov 14, 2019
@aeschli aeschli added this to the November 2019 milestone Nov 14, 2019
@aeschli aeschli changed the title Unquoted HTML attributes are parsed/displayed incorrectly [html] Unquoted HTML attributes are parsed/displayed incorrectly Nov 14, 2019
@mjbvz mjbvz added the verification-found Issue verification failed label Dec 4, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 4, 2019

Still seeing this in 7f1975a

@mjbvz mjbvz reopened this Dec 4, 2019
@aeschli aeschli mentioned this issue Dec 5, 2019
Closed
@aeschli
Copy link
Contributor

aeschli commented Dec 5, 2019

Sorry, I forgot to add that I just fixed the link detection.
Formatting is done by jsbeautify: beautifier/js-beautify#1736

@aeschli aeschli closed this as completed Dec 5, 2019
@aeschli aeschli removed the verification-found Issue verification failed label Dec 5, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 6, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
4 participants
@RMacfarlane @aeschli @mjbvz @Aloso