Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to have scoped instantiation service per editor slot #8579

Closed
bpasero opened this issue Jun 30, 2016 · 4 comments
Closed

Allow to have scoped instantiation service per editor slot #8579

bpasero opened this issue Jun 30, 2016 · 4 comments
Assignees
Labels
verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 30, 2016

For:

  • scoped keybinding service
  • scoped progress service

For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around.

Enables more scenarios around menu and command contributions for contexts.

@bpasero bpasero added this to the July 2016 milestone Jun 30, 2016
@bpasero bpasero self-assigned this Jun 30, 2016
@bpasero bpasero changed the title Allow to have scoped keybinding service per editor slot Allow to have scoped instantiation service per editor slot Jul 1, 2016
@egamma egamma mentioned this issue Jul 12, 2016
89 tasks
bpasero added a commit that referenced this issue Jul 14, 2016
@bpasero
Copy link
Member Author

bpasero commented Jul 14, 2016

@jrieken I merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group.

Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again.

image

@bpasero bpasero closed this as completed Jul 14, 2016
@jrieken
Copy link
Member

jrieken commented Jul 14, 2016

I can verify

@jrieken
Copy link
Member

jrieken commented Jul 14, 2016

LGTM - will push the revert revert commit

@Tyriar
Copy link
Member

Tyriar commented Jul 27, 2016

Verified via #9693

@Tyriar Tyriar added the verified Verification succeeded label Jul 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants