-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to have scoped instantiation service per editor slot #8579
Comments
@jrieken I merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. |
I can verify |
LGTM - will push the revert revert commit |
Verified via #9693 |
For:
For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around.
Enables more scenarios around menu and command contributions for contexts.
The text was updated successfully, but these errors were encountered: