Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact folder rendering looks weird #86025

Closed
jrieken opened this issue Dec 3, 2019 · 8 comments
Closed

Compact folder rendering looks weird #86025

jrieken opened this issue Dec 3, 2019 · 8 comments
Assignees

Comments

@jrieken
Copy link
Member

jrieken commented Dec 3, 2019

re #85928

IMO we had a much better in-between solution using chevrons or no spacing. To me the slash and the spacing look like screen cheese.

Screenshot 2019-12-03 at 11 18 27

Screenshot 2019-12-03 at 11 18 07

@jrieken
Copy link
Member Author

jrieken commented Dec 3, 2019

Proposal: Use normal character spacing and opacity

Screenshot 2019-12-03 at 11 50 30

@joaomoreno
Copy link
Member

Closing this for now and waiting for more user feedback.

@gabeklein
Copy link

Personally I'd like to see an option to make nested folders less prominent (lighter, less opacity). Reason being that usually the root folder is the relevant, most "unique" folder and should be visually more prominent.

@gjsjohnmurray
Copy link
Contributor

@gabeklein by "the root folder" do you mean the leftmost one on the sequence? In other words, you'd like the opposite of what @jrieken proposed in his screenshot here?

@gabeklein
Copy link

gabeklein commented Feb 17, 2020

@gjsjohnmurray

Yep, basically I tend to work with a mono-repo and have a good number of packages (in my node projects) I'll tend to use files.exclude to make only items in /src visible and togglable to get a "Zen"-like experience in my explorer.

Screenshot 2020-02-17 at 9 51 54 AM

This is what it looks like with compact folders active. Not the easiest to scan quickly while hopping between modules. ⬇ And here this is without.

Screenshot 2020-02-17 at 9 56 16 AM

Since the package's root folder is the most relevant thing to me personally, having /src be less prominent would help me comfortably scan a large number of packages like this while still enjoying the benefits of compact mode.

If I had a way to explicitly set the opacity of /src ect... I'd make it close to zero, resulting in the second image just without the extra line for subfolder. It'd make my development experience a lot more comfortable.

Just my personal take on this issue. 🙂 Thanks for responding

@joaomoreno
Copy link
Member

If I had a way to explicitly set the opacity of /src ect... I'd make it close to zero, resulting in the second image just without the extra line for subfolder. It'd make my development experience a lot more comfortable.

What if you had the possibility of letting the explorer know that express and interface and webpack should not be folded up?

@gabeklein
Copy link

@joaomoreno Sorry I don't really follow, could you explain?

@joaomoreno
Copy link
Member

I mean: a workspace setting that you could mark certain folders never to be folded up. I believe your argument has something to do with the lib/* folders, and not just any folder, being folded up with a single child.

So we could offer a setting, e.g. explorer.preventCompactFolder which would have a glob pattern value, eg. lib/*, and the explorer wouldn't render those folders as compact, even if they only have a single child.

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants