Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tunnels view: keyboard shortcuts missing #86065

Closed
isidorn opened this issue Dec 3, 2019 · 3 comments
Closed

Tunnels view: keyboard shortcuts missing #86065

isidorn opened this issue Dec 3, 2019 · 3 comments
Assignees
@alexr00
Labels
feature-request Request for new features or functionality polish Cleanup and polish issue remote Remote system operations issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 3, 2019 •
edited
Loading

Refs #85926

Tunnels view, keyboard focus on a forwarded port.
Cmd + backspace on Mac and Delete on Win / Linux should delete the forwarded port.

Similarly if the Open in Browser is the only "positive" primary actions space and enter should open the port in browser.
F2 could rename the port also. On mac this might be what should happen on Enter.
@isidorn isidorn changed the title Tunnles view: keyboard shortcuts missing Tunnels view: keyboard shortcuts missing Dec 3, 2019
@alexr00 alexr00 added feature-request Request for new features or functionality polish Cleanup and polish issue remote Remote system operations issues labels Dec 3, 2019
@alexr00 alexr00 added this to the December 2019 milestone Dec 3, 2019
alexr00 added a commit that referenced this issue Jan 22, 2020
@alexr00
Add delete keyboard shortcut for forwarded ports
03c529d 
Part of #86065
alexr00 added a commit that referenced this issue Jan 22, 2020
@alexr00
Add label keyboard shortcut for forwarded ports view
b83d321 
Part of #86065
@alexr00
Copy link
Member

alexr00 commented Jan 22, 2020

Added the rename and the delete as suggested.
I added Copy address with keyboard shortcut ctrl/cmd +c.

@alexr00
Copy link
Member

alexr00 commented Jan 27, 2020

To verify, try the rename, delete, and copy keyboard shortcuss in the forwarded ports view.

@alexr00 alexr00 added the verification-needed Verification of issue is requested label Jan 27, 2020
@isidorn isidorn added the verified Verification succeeded label Jan 28, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Jan 28, 2020

Adding verified with the exception of microsoft/vscode-remote-release#2221

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality polish Cleanup and polish issue remote Remote system operations issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2020
Development

No branches or pull requests
2 participants
@isidorn @alexr00