Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open editors: briefly shows "1 unsaved" even though auto save is on #86553

Closed
bpasero opened this issue Dec 8, 2019 · 0 comments
Closed

Open editors: briefly shows "1 unsaved" even though auto save is on #86553

bpasero opened this issue Dec 8, 2019 · 0 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken verified Verification succeeded
Milestone
November 2019

Comments

@bpasero
Copy link
Member

bpasero commented Dec 8, 2019

A regression from the work of custom editors, when typing into an editor with auto save on (after 1s delay), we typically do not show any dirty indicators. However, the open editors view still shows them:

Kapture 2019-12-08 at 9 31 58
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken labels Dec 8, 2019
@bpasero bpasero added this to the November 2019 milestone Dec 8, 2019
@bpasero bpasero self-assigned this Dec 8, 2019
bpasero added a commit that referenced this issue Dec 9, 2019
@bpasero
fix #86553
63632db
@bpasero bpasero mentioned this issue Dec 9, 2019
Merged
@bpasero bpasero closed this as completed in 95ce364 Dec 9, 2019
@bpasero bpasero reopened this Dec 9, 2019
bpasero added a commit that referenced this issue Dec 9, 2019
@bpasero
fix #86553 (#86578)
5442190
@bpasero bpasero closed this as completed Dec 9, 2019
@isidorn isidorn added the verified Verification succeeded label Dec 10, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
2 participants
@bpasero @isidorn