Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompressedNavigationController ends with outdated state after startup #86573

Closed
jeanp413 opened this issue Dec 9, 2019 · 4 comments · Fixed by #86574
Closed

CompressedNavigationController ends with outdated state after startup #86573

jeanp413 opened this issue Dec 9, 2019 · 4 comments · Fixed by #86574
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-explorer Explorer widget issues verified Verification succeeded
Milestone
November 2019

Comments

@jeanp413
Copy link
Contributor

jeanp413 commented Dec 9, 2019

Tested from sources

Steps to Reproduce:

  1. Open (or reload) a workspace with compressed folders containing file decorations.
  2. 🐛 Keyboard focus the explorer and observe it's not possible to navigate the compressed labels.
  3. 🐛 Right click on a compressed label to show the context menu. Observe the context menu appears at the top left corner of the window.

compressedfolder
@vscodebot
Copy link

vscodebot bot commented Dec 9, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

jeanp413 added a commit to jeanp413/vscode that referenced this issue Dec 9, 2019
@jeanp413
Fixes microsoft#86573
e9e9bde
@jeanp413 jeanp413 mentioned this issue Dec 9, 2019
Merged
@gjsjohnmurray
Copy link
Contributor

@joaomoreno maybe the PR from @jeanp413 can be a candidate for 1.41 ?

@isidorn
Copy link
Contributor

isidorn commented Dec 9, 2019

@jeanp413 thanks a lot for filling this!
I can reproduce this issue.
Adding candidate label

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-explorer Explorer widget issues labels Dec 9, 2019
@isidorn isidorn added this to the November 2019 milestone Dec 9, 2019
@isidorn
Copy link
Contributor

isidorn commented Dec 9, 2019

I have merged to master a great PR by @jeanp413
However reopening this issue so we dicuss if the issue should be part of the release, if yes I will create a new PR which dulicates the @jeanp413 fix to our release branch.

@isidorn isidorn reopened this Dec 9, 2019
@isidorn isidorn mentioned this issue Dec 10, 2019
Merged
@isidorn isidorn closed this as completed Dec 10, 2019
@bpasero bpasero added the verified Verification succeeded label Dec 10, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

Successfully merging a pull request may close this issue.

Fixes compressedNavigationController ends with outdated state after startup jeanp413/vscode
4 participants
@bpasero @isidorn @gjsjohnmurray @jeanp413