-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show errors returned from sourceRequest #8836
Labels
Milestone
Comments
weinand
added
the
debug
Debug viewlet, configurations, breakpoints, adapter issues
label
Jul 7, 2016
@isidorn this is how the error messages looks like: Especially ugly is the line number '1' for the error message and that the execution line and the arrow is shown. (This is meant as input to the UX design meeting) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Today errors returned from the
sourceRequest
are only visible on the dev console.For that reason the sourceRequest implementation of node-debug manufactures content that contains the error message and returns success.
I've cleaned that up and now node-debug returns proper errors.
For the UI we have these option:
Option 1 is too heavy because the user has to dismiss the notification.
Option 2 is what we have today but implemented on the 'correct' side.
Option 3 would be the best solution.
For now 2 is fine by me, but we should involve UX to design something for 3.
The text was updated successfully, but these errors were encountered: