Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show errors returned from sourceRequest #8836

Closed
weinand opened this issue Jul 7, 2016 · 1 comment
Closed

Show errors returned from sourceRequest #8836

weinand opened this issue Jul 7, 2016 · 1 comment
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jul 7, 2016

Today errors returned from the sourceRequest are only visible on the dev console.

For that reason the sourceRequest implementation of node-debug manufactures content that contains the error message and returns success.

I've cleaned that up and now node-debug returns proper errors.

For the UI we have these option:

  1. workbench error notification
  2. manufacturing an editor content for the error and showing this in the editor
  3. having a '404'-like error page instead misusing an editor for that.

Option 1 is too heavy because the user has to dismiss the notification.
Option 2 is what we have today but implemented on the 'correct' side.
Option 3 would be the best solution.

For now 2 is fine by me, but we should involve UX to design something for 3.

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 7, 2016
@weinand weinand added this to the July 2016 milestone Jul 7, 2016
@isidorn isidorn closed this as completed in cd7fb30 Jul 7, 2016
@weinand
Copy link
Contributor Author

weinand commented Jul 7, 2016

@isidorn this is how the error messages looks like:

2016-07-07_16-58-01

Especially ugly is the line number '1' for the error message and that the execution line and the arrow is shown.

(This is meant as input to the UX design meeting)

@weinand weinand added the verified Verification succeeded label Jul 7, 2016
jrieken pushed a commit that referenced this issue Jul 12, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants