Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Markdown settings for highlightjs theme #9136

Closed
jods4 opened this issue Jul 12, 2016 · 2 comments
Closed

Suggestion: Markdown settings for highlightjs theme #9136

jods4 opened this issue Jul 12, 2016 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality markdown Markdown support issues
Milestone

Comments

@jods4
Copy link

jods4 commented Jul 12, 2016

The markdown extension uses highlight.js for code highlighting, which comes with many themes inside its styles folder.

Yet, the default theme (tomorrow.css) is hardcoded here:
https://github.com/Microsoft/vscode/blob/master/extensions/markdown/src/extension.ts#L237

It is possible to override this by finding and copying the theme you like into your project and referencing the file with markdown.styles settings. This work but it's not easy/intuitive and it does not actually remove the tomorrow rules/stylesheet from the document (which can provide some unwanted defaults).

I suggest that you make the default theme easily changeable with a new settings, maybe markdown.highlightStyle: "tomorrow" and support all the hightlight.js built-in styles.

BTW I think tomorrow is a very colorful choice for a default settings, but that's just my taste.

@mjbvz mjbvz added feature-request Request for new features or functionality markdown Markdown support issues labels Sep 27, 2016
@mjbvz mjbvz self-assigned this Sep 27, 2016
mjbvz added a commit to mjbvz/vscode that referenced this issue Sep 28, 2016
Issue microsoft#9136

Allows users to specify which highlight.js theme they would like to use for the markdown preview. These themes are bundled in highlight.js.

closes microsoft#9136
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 25, 2016
Issue microsoft#9136

Allows users to specify which highlight.js theme they would like to use for the markdown preview. These themes are bundled in highlight.js.

closes microsoft#9136
@mjbvz mjbvz modified the milestone: Backlog Feb 23, 2017
@kieferrm kieferrm removed their assignment Apr 21, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 2, 2017

Closing in favor of #22916 Let me know if you are interested in developing a markdown extension that can provide this functionality

@mjbvz mjbvz closed this as completed May 2, 2017
@jods4
Copy link
Author

jods4 commented May 2, 2017

Sorry, I don't have the time to look into VS Code extensions, although that looks like an exciting area.

If I had more time, I would surely try to add AsciiDocs support. There are some extensions in the market place but only one supports preview and it needs a globally installed Python AsciiDoctor, even though a perfectly fine AsciiDoctor.js exists!?

I've recently come to love AsciiDocs as a much better LML than Markdown.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality markdown Markdown support issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants