Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace <sha>^ with the previous sha (or something more acceptable) in the diff editor title #91377

Closed
alexdima opened this issue Feb 25, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug timeline Timeline view issues verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

Testing #91329

When viewing the timeline for a file, and clicking on the item, the title looks like:
image

Two things stand out:

  • there appears to be a unicode string encoding issue, where the unicode code point is escaped \u27f7
  • the same commit sha is rendered twice, once with sha^ format, which is very technical and not user friendly IMHO. I recommend to try to render the sha only once.
@eamodio eamodio added bug Issue identified by VS Code Team member as probable bug timeline Timeline view issues labels Feb 25, 2020
@eamodio eamodio added this to the Backlog milestone Feb 25, 2020
eamodio pushed a commit that referenced this issue Feb 27, 2020
@eamodio
Copy link
Contributor

eamodio commented Feb 28, 2020

I've fixed the encoding problem, but will still need to address the previous sha (<sha>^) issue

@eamodio eamodio modified the milestones: Backlog, March 2020 Feb 28, 2020
@eamodio eamodio changed the title Funny diff editor name Replace <sha>^ with the previous sha (or something more acceptable) in the diff editor title Feb 28, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug timeline Timeline view issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants