Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to sync notification comes too early #91584

Closed
aeschli opened this issue Feb 26, 2020 · 2 comments
Closed

Unable to sync notification comes too early #91584

aeschli opened this issue Feb 26, 2020 · 2 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug settings-sync verified Verification succeeded
Milestone
February 2020

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 26, 2020

Testing #91226

  • enable setting sync
  • in the setting JSON editor, star adding color customization
  • In the middle of typing you get a notification

image

  • it would be better to wait a bit as I'm just in the middle of editing.
  • maybe a symbol on the status bar would be better to indicate that syncing is halted
  • can there be warnings that prevent syncing or is it just errors?
  • Uppercase/lowercase: the button should be Open Settings File and the text should say Unable to sync settings...
@aeschli
Copy link
Contributor Author

aeschli commented Feb 26, 2020 •
edited
Loading

image
Again 'Settings' should be lower case.

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug settings-sync labels Feb 26, 2020
@sandy081 sandy081 added this to the February 2020 milestone Feb 26, 2020
sandy081 added a commit that referenced this issue Feb 26, 2020
@sandy081
#91584 convert to lower case
9db2563
@Tyriar
Copy link
Member

Tyriar commented Feb 27, 2020

I think @chrisdias mentioned this today as autosave was on.

@roblourens roblourens added the verified Verification succeeded label Feb 28, 2020
@sandy081 sandy081 mentioned this issue Feb 28, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug settings-sync verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
4 participants
@roblourens @Tyriar @aeschli @sandy081