Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API support to cancel showInputBox #9377

Closed
siegebell opened this issue Jul 16, 2016 · 2 comments
Closed

API support to cancel showInputBox #9377

siegebell opened this issue Jul 16, 2016 · 2 comments
Assignees
@jrieken
Labels
api feature-request Request for new features or functionality
Milestone
August 2016

Comments

@siegebell
Copy link

Feature request: API support to cancel showInputBox. E.g. add a vscode.CancellationToken to its options.

Example use case: I've implemented a custom text search, using the validateInput option to update the search as the user types. Certain events cancel the search, in which case, the input box should disappear.
@weinand weinand added feature-request Request for new features or functionality api labels Jul 16, 2016
@siegebell siegebell mentioned this issue Jul 18, 2016
Closed
@jrieken
Copy link
Member

jrieken commented Jul 20, 2016

makes sense

@jrieken jrieken added this to the August 2016 milestone Aug 8, 2016
jrieken added a commit that referenced this issue Aug 8, 2016
@jrieken
add cancellation support for showInput and showQuickPick, #9377
ff06190
@jrieken
Copy link
Member

jrieken commented Aug 8, 2016

@siegebell This just landed in master. Please try it out

@jrieken jrieken closed this as completed Aug 9, 2016
@jrieken jrieken mentioned this issue Aug 29, 2016
Closed
1 task
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api feature-request Request for new features or functionality
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
3 participants
@jrieken @weinand @siegebell