Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick access: creating new entry should be aligned between debug, terminal and tasks #93864

Closed
isidorn opened this issue Mar 31, 2020 · 8 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues quick-open Quick-open issues (search, commands) tasks Task system issues terminal General terminal issues that don't fall under another label under-discussion Issue is under discussion for relevance, priority, approach wont-fix
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

Refs: #93641

Note how the terminal uses a nice + icon before the Create New Terminal.
I belive we should use the same icon before the Add Configuration for debug.

Also the tasks should ideally have a similar Add Task experience in theri quick access.

Screenshot 2020-03-31 at 11 19 46

@bpasero bpasero assigned Tyriar and unassigned bpasero Mar 31, 2020
@bpasero bpasero added terminal General terminal issues that don't fall under another label quick-pick Quick-pick widget issues labels Mar 31, 2020
@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

Unrelated to my changes, assigning respective owners.

@bpasero bpasero added debug Debug viewlet, configurations, breakpoints, adapter issues tasks Task system issues labels Mar 31, 2020
@alexr00
Copy link
Member

alexr00 commented Mar 31, 2020

The Run Task command and "task " quick access are finally converged and I only show the "Configure Task..." option (which is the equivalent of add for tasks) when there aren't tasks already configured. I will put a + in front of the "Configure task..." so it matches.

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2020

@alexr00 for configure a gear would be more appropriate, no?

Also I see no "Configure Task..." option outside of the icon when you hit show all tasks?

image

image

@alexr00
Copy link
Member

alexr00 commented Mar 31, 2020

@Tyriar I only show the "Configure Task..." option (which is the equivalent of add for tasks) when there aren't tasks already configured. A gear is more appropriate as it's what is used for the configure tasks button, but then it is not consistent with terminal.

I do not feel strongly about whether an icon is added to Configure tasks, but it seems like no matter what it will not be consistent with terminal and debug. Because of this, I would prefer not to add an icon.

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2020

@alexr00 how about "+ Create a task" or "+ Configure a task"?

@isidorn
Copy link
Contributor Author

isidorn commented Apr 1, 2020

Whatever you agree on I will happily align with in Debug :)

@alexr00
Copy link
Member

alexr00 commented Apr 1, 2020

I'll change it to "+ Configure a task". It will still only show if there are no configured tasks.

@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 4, 2020
@rzhao271 rzhao271 added this to the Backlog milestone Nov 5, 2020
@alexr00
Copy link
Member

alexr00 commented Nov 6, 2020

Changed:
image

alexr00 added a commit that referenced this issue Nov 6, 2020
@alexr00 alexr00 removed their assignment Nov 6, 2020
@Tyriar Tyriar removed their assignment Nov 6, 2020
@bpasero bpasero added quick-open Quick-open issues (search, commands) and removed quick-pick Quick-pick widget issues labels Apr 7, 2021
@isidorn isidorn closed this as completed Aug 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues quick-open Quick-open issues (search, commands) tasks Task system issues terminal General terminal issues that don't fall under another label under-discussion Issue is under discussion for relevance, priority, approach wont-fix
Projects
None yet
Development

No branches or pull requests

5 participants