-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick access: creating new entry should be aligned between debug, terminal and tasks #93864
Comments
Unrelated to my changes, assigning respective owners. |
The Run Task command and "task " quick access are finally converged and I only show the "Configure Task..." option (which is the equivalent of add for tasks) when there aren't tasks already configured. I will put a + in front of the "Configure task..." so it matches. |
@alexr00 for configure a gear would be more appropriate, no? Also I see no "Configure Task..." option outside of the icon when you hit show all tasks? |
@Tyriar I only show the "Configure Task..." option (which is the equivalent of add for tasks) when there aren't tasks already configured. A gear is more appropriate as it's what is used for the configure tasks button, but then it is not consistent with terminal. I do not feel strongly about whether an icon is added to Configure tasks, but it seems like no matter what it will not be consistent with terminal and debug. Because of this, I would prefer not to add an icon. |
@alexr00 how about "+ Create a task" or "+ Configure a task"? |
Whatever you agree on I will happily align with in Debug :) |
I'll change it to "+ Configure a task". It will still only show if there are no configured tasks. |
Refs: #93641
Note how the terminal uses a nice + icon before the Create New Terminal.
I belive we should use the same icon before the Add Configuration for debug.
Also the tasks should ideally have a similar Add Task experience in theri quick access.
The text was updated successfully, but these errors were encountered: