Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new theme color for drag feedback indicator lines #94041

Closed
eamodio opened this issue Mar 31, 2020 · 3 comments
Closed

Add new theme color for drag feedback indicator lines #94041

eamodio opened this issue Mar 31, 2020 · 3 comments
Assignees
@sbatten @miguelsolorio
Labels
themes Color theme issues workbench-views Workbench view issues
Milestone
May 2020

Comments

@eamodio
Copy link
Contributor

eamodio commented Mar 31, 2020

Refs: #93786

I would like to see 2 new theme colors -- 1 for the activity bar / panel header and one for the intra-sidebar/panel.

For example, I would want to be able to theme the white line here to be a lighter/brighter purple.
image

And possibly a different color/brightness here as there is no background color in addition to the indicator.
image
@sbatten sbatten added this to the April 2020 milestone Apr 1, 2020
@miguelsolorio miguelsolorio added the themes Color theme issues label Apr 1, 2020
@sbatten sbatten modified the milestones: April 2020, May 2020 Apr 27, 2020
@sbatten sbatten added the workbench-views Workbench view issues label May 7, 2020
sbatten added a commit that referenced this issue May 20, 2020
@sbatten
refs #94041
8e67cd2
@sbatten
Copy link
Member

sbatten commented May 20, 2020 •
edited
Loading

@eamodio added 2 keys for the dnd in activity bar and panel titles. do you think we still need the keys for dnd border with views? that only shows up in the collapsed view and is using the active contrast border key to be themed. I'm always in favor of less keys if possible. reopen if so

@sbatten sbatten closed this as completed May 20, 2020
@eamodio
Copy link
Contributor Author

eamodio commented May 20, 2020

@sbatten I think the border I was thinking about would be visible all the time (on the left) -- just like the top border color in the side bar. Could we just re-use that top border color?

@sbatten
Copy link
Member

sbatten commented May 20, 2020

That would mean you would see 2 borders of the same color, yes?

robertrossmann added a commit to robertrossmann/vscode-remedy that referenced this issue May 21, 2020
@robertrossmann
feat: add new panel-related colour contributions 🎨
7a1441d 
See microsoft/vscode#94041
See microsoft/vscode#94339
github-actions bot pushed a commit to robertrossmann/vscode-remedy that referenced this issue May 21, 2020
@semantic-release-bot
chore(release): 4.16.0 [skip ci]
9e5ff08 
# [4.16.0](4.15.0...4.16.0) (2020-05-21)

### Bug Fixes

* make the notification toast's border less intrusive ([057b829](057b829))
* use contrasting foreground colour for debug button in Status bar ([dfe3161](dfe3161))
* use contrasting foreground colour for notification center header ([26efd03](26efd03))

### Features

* add new panel-related colour contributions 🎨 ([7a1441d](7a1441d)), closes [microsoft/vscode#94041](microsoft/vscode#94041) [microsoft/vscode#94339](microsoft/vscode#94339)
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

@miguelsolorio miguelsolorio

Labels
themes Color theme issues workbench-views Workbench view issues
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
3 participants
@eamodio @sbatten @miguelsolorio