Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cygwin in the default shell selector #94473

Closed
rajinder-yadav opened this issue Apr 5, 2020 · 7 comments · Fixed by #118790
Closed

Support cygwin in the default shell selector #94473

rajinder-yadav opened this issue Apr 5, 2020 · 7 comments · Fixed by #118790
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@rajinder-yadav
Copy link

Issue Type: Feature Request

Cygwin shell is not supported in vscode, would like to see this made available.

cygwin

VS Code version: Code - Insiders 1.43.0-insider (e6a45f4, 2020-02-21T05:40:52.685Z)
OS version: Linux x64 5.5.13-1-default

@IllusionMH
Copy link
Contributor

Have you tried to add path to executable manually?

@Tyriar
Copy link
Member

Tyriar commented Apr 6, 2020

I tried adding cygwin to that dropdown a while ago but ran into problems as it needs special arguments to work and currently the "profiles" in the shell selector don't support args. See https://stackoverflow.com/q/46061894/1156119 for how to use it manually.

@Tyriar Tyriar changed the title support cygwin as a shell for terminal integration Support cygwin in the default shell selector Apr 6, 2020
@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label windows VS Code on Windows issues labels Apr 6, 2020
@Tyriar Tyriar added this to the Backlog milestone Apr 6, 2020
@rajinder-yadav
Copy link
Author

@Tyriar Just a suggestion, maybe open a ticket requesting support for what you need to get cygwin working with vscode? I'm sure the cygwin team would welcome this.

I'll take a look at the link you provided, thanks.

@Tyriar
Copy link
Member

Tyriar commented Apr 6, 2020

@rajinder-yadav I don't think we need anything in particular, more of a problem on our end that the shell selector only sets the executable currently, not the args.

@rajinder-yadav
Copy link
Author

@Tyriar the stackoverflow tip worked for me as a work-around thanks!

@meganrogge meganrogge self-assigned this Mar 9, 2021
@meganrogge meganrogge modified the milestones: Backlog, March 2021 Mar 9, 2021
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Mar 22, 2021
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Mar 23, 2021

@meganrogge I noticed that cygwin isn't here:
image
but it is here:
image

is that expected? If so feel free to remove verification-found and mark as verified

@TylerLeonhardt TylerLeonhardt added the verification-found Issue verification failed label Mar 23, 2021
@Tyriar
Copy link
Member

Tyriar commented Mar 23, 2021

@TylerLeonhardt that's by design, the thinking here being that cygwin wouldn't be used as often as the others so you need to explicitly add it.

@TylerLeonhardt TylerLeonhardt added verified Verification succeeded and removed verification-found Issue verification failed labels Mar 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@rajinder-yadav @IllusionMH @Tyriar @TylerLeonhardt @meganrogge and others