Problem Count Gets Associated With Wrong Tab in Panel When Views Are Dragged

[0xbarrett]

• VSCode Version: 1.44.1
• OS Version: MacOS 10.14.6

Steps to Reproduce:

1. In the lower panel, drag the Terminal view tab onto the Problems view and then place it to the left of the Problems view, combining the two views into one panel.
   
   

2. Drag the Problems view back up to the tab bar, removing it from the panel.
   

Expected results:
The Problem Count is displayed to the right of the "Problems" tab

Actual results:
The Problem Count is displayed to the right of the "Terminal" tab.

Does this issue occur when all extensions are disabled?: Yes/No
I can't reproduce the issue when extensions are disabled because the Count does not appear on the Problems tab. This is likely because no extensions are running to search the code for problems. I imagine that the problem would persist if there was a "Count" on the Problems tab.

[sandy081]

@sbatten Is this because of reusing the problems view container for terminal view but using the title of terminals view?

[sandy081]

Introduced following

• IActivityService.showViewContainerActivity - to set the activity for the given container
• ViewContaierActivityByView - that sets the activity for a given view on appropriate container