Notebook: executing cells turns editor dirty?

[bpasero]

Refs: #96279

I executed the notebook and wasn't sure why this turns the document dirty? We are surely not writing the results into the file are we?

[jrieken]

Yeah, that's something we need to look at. Notebooks can and often do save the output (we have decided against that for issues notebooks) but currently notebook extensions cannot control that, it's the UI that does this (and it shouldn't). For instance, an issues notebook shouldnt become dirty when running but for instance it should become dirty when lock/unlock a cell (since that's saved to disk)

[bpasero]

What worries me more is that my input seems to get lost a lot. Is the cell input not saved into the file?

[jrieken]

The input should always be saved! Internally, all cells are collected and then vscode.workspace.fs is used to write a blob of JSON text

[jrieken]

@rebornix Is this still the core or did you move this already to the extension side? My plan is

• running doesn't change dirty change (e.g no change event)
• lock/unlock cell does emit a change event so that the UI can show dirty

[jrieken]

I have pushed a change that propagates NotebookContentProvider#onDidChangeNotebook, internally that's exposed as INotebookTextModel#onDidChangeUnknown. Still work to do, eg. for having undoable change events...

[jrieken]

Turns out this was done on purpose via #94073, 8f82b87. I will go ahead and undo those changes. Extensions that do want to save output should have all the necessary events and API by now (e.g listen to output change, emit dirty/change event)

[jrieken]

closed via 99fa777