Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Net Promoter Score feedback support #9686

Closed
egamma opened this issue Jul 25, 2016 · 7 comments
Closed

Add Net Promoter Score feedback support #9686

egamma opened this issue Jul 25, 2016 · 7 comments
Assignees
Labels
plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@egamma
Copy link
Member

egamma commented Jul 25, 2016

CC @seanmcbreen

fwlink to the survey: http://go.microsoft.com/fwlink/?LinkId=823149

@egamma egamma added the plan-item VS Code - planned item for upcoming label Jul 25, 2016
@egamma egamma added this to the July 2016 milestone Jul 25, 2016
@joaomoreno
Copy link
Member

joaomoreno commented Jul 25, 2016

@egamma @seanmcbreen Can I get a review over the following description?

We should propose the user to answer the NPS score after a fixed amount of sessions. The proposal should occur with a certain degree of probability. If the survey happens to not be shown, it will not be shown again to this user. The user can opt to either get asked again later or not get asked again.

  • A session is an execution of VSCode, capping at the maximum of one per day.
  • The survey should be proposed at the 9th session.
  • The probability of being proposed is 15%.
  • If the user requests to do the survey later, we should propose it at the 12th, 15th session, etc.
  • Any of following outcomes will result in never asking the user again (until we release a new version that overwrites this):
    • User clicks the Don't ask again button
    • User clicks the Yes, let's answer the survey button
    • User is part of the 85% of users that didn't get selected for the survey proposal

@egamma
Copy link
Member Author

egamma commented Jul 25, 2016

@joaomoreno this captures well what we discussed, but I defer to @seanmcbreen since he did the spec.

joaomoreno added a commit that referenced this issue Jul 25, 2016
related to #9686
@joaomoreno
Copy link
Member

Pushed 5bcde31 containing the logic described above. nps.contribution.ts is the interesting part.

@egamma egamma mentioned this issue Jul 25, 2016
89 tasks
@joaomoreno
Copy link
Member

I've also set the npsSurveyUrl key in the product.json of both stable and insiders, in the distro repo. Should it be the same URL, @seanmcbreen?

I'll assign this to someone, needs a code review.

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Jul 25, 2016
@joaomoreno joaomoreno assigned jrieken and unassigned joaomoreno Jul 25, 2016
@joaomoreno joaomoreno added verification-needed Verification of issue is requested and removed info-needed Issue requires more information from poster labels Jul 25, 2016
@joaomoreno
Copy link
Member

@jrieken Can you review? Let me know if you'd like me to run you through the code, might be easier.

@joaomoreno
Copy link
Member

@jrieken I take it back, I'll just create a test plan item and let it be assigned. No op here.

@Tyriar
Copy link
Member

Tyriar commented Jul 27, 2016

Verified in #9690

@Tyriar Tyriar added the verified Verification succeeded label Jul 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants