Bad layout for images in diff view #96968
Assignees
Labels
Milestone
Comments
mjbvz
added
bug
|
This was caused by ea07e9b @sbatten (not sure if you are the correct owner) For May, I suggest we investigate why the For April, I'll add a ugly workaround that should be safer |
mjbvz
added a commit
that referenced
this issue
May 5, 2020
Fix for #96968 This is a scoped fix for #96968. The cause of the issue is the following: 1. Webview must be rendered outside of the main editor DOM. We do this by absolutely positioning them over some element in the DOM. 1. In split views, we try to lay the webview out over an element that has 0 height. 1. Due to my workaround in ea07e9b, this causes the webview to either not show at all (because it also will have zero height) or partially show This fix forces the webivew's parent in the split view to have 100%. That actually seems like a reasonable default but I've scoped my fix to just webviews
mjbvz
added a commit
to mjbvz/vscode
that referenced
this issue
May 5, 2020
Fix for microsoft#96968 This is a scoped fix for microsoft#96968. The cause of the issue is the following: 1. Webview must be rendered outside of the main editor DOM. We do this by absolutely positioning them over some element in the DOM. 1. In split views, we try to lay the webview out over an element that has 0 height. 1. Due to my workaround in ea07e9b, this causes the webview to either not show at all (because it also will have zero height) or partially show This fix forces the webivew's parent in the split view to have 100%. That actually seems like a reasonable default but I've scoped my fix to just webviews
mjbvz
added a commit
to mjbvz/vscode
that referenced
this issue
May 5, 2020
Fix for microsoft#96968 This is a scoped fix for microsoft#96968. The cause of the issue is the following: 1. Webview must be rendered outside of the main editor DOM. We do this by absolutely positioning them over some element in the DOM. 1. In split views, we try to lay the webview out over an element that has 0 height. 1. Due to my workaround in ea07e9b, this causes the webview to either not show at all (because it also will have zero height) or partially show This fix forces the webivew's parent in the split view to have 100%. That actually seems like a reasonable default but I've scoped my fix to just webviews
mjbvz
added a commit
that referenced
this issue
May 5, 2020
Fix for #96968 This is a scoped fix for #96968. The cause of the issue is the following: 1. Webview must be rendered outside of the main editor DOM. We do this by absolutely positioning them over some element in the DOM. 1. In split views, we try to lay the webview out over an element that has 0 height. 1. Due to my workaround in ea07e9b, this causes the webview to either not show at all (because it also will have zero height) or partially show This fix forces the webivew's parent in the split view to have 100%. That actually seems like a reasonable default but I've scoped my fix to just webviews
mjbvz
added a commit
that referenced
this issue
May 5, 2020
Removes the workaround for maximizing the panel. Instead track if the editor is visible and only lay the view out if the editor is visible
|
Merged fix into 1.45 Checked better fix into master with f761228 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Issue Type: Bug
Repro
Bug
The webview for the image preview can be poorly laid out (or hidden entirely)
VS Code version: Code - Insiders 1.45.0-insider (fd5d9a3, 2020-05-04T09:21:17.770Z)
OS version: Darwin x64 19.4.0
System Info
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
The text was updated successfully, but these errors were encountered: