-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move generic hover widget to base ui and extend in ContentHoverWidget #97496
Comments
We could also expose the widget in a HoverService for ease of use in the workbench, this would handle:
See dialog and context menu service for similar services. |
FYI we may also want to reset the hover when the target element's position changes in the workbench. We had an issue in Notebook that when the notebook scrolls, the hover doesn't go away as its relative position to the Monaco Editor container doesn't change. Now with the hover being promoted to workbench/service level, we can fix this issue by having position monitoring on the hover target. (but not sure about the perf penalty) |
@rebornix the notebook would still use the editor's version and its lifecycle management though. For the workbench-level hover the plan is to ensure only a single hover shows at a time. |
To verifier: test the hover and its overflow behavior by:
|
No description provided.
The text was updated successfully, but these errors were encountered: