Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The terminal IME composition view appears on top of the text when at the bottom of the screen #9822

Closed
Tyriar opened this issue Jul 26, 2016 · 3 comments
Closed

The terminal IME composition view appears on top of the text when at the bottom of the screen #9822

Tyriar opened this issue Jul 26, 2016 · 3 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
August 2016

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 26, 2016

See it appears on top of the second character being composed.

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Jul 26, 2016
@Tyriar Tyriar self-assigned this Jul 26, 2016
@Tyriar Tyriar added this to the August 2016 milestone Jul 26, 2016
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 26, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Jul 26, 2016

Upstream issue: xtermjs/xterm.js#208

@Tyriar Tyriar closed this as completed in b639303 Aug 18, 2016
@rebornix rebornix added the verification-found Issue verification failed label Aug 31, 2016
@rebornix
Copy link
Member

@Tyriar not sure which language you were typing on what platform when you found the issue, but the behavior on Mac with Chinese IME is not that perfect, see below gif

imeinterminal

While typing nihao, the text is sometimes covered by the IME hint popup and while typing constnatly, the popup keeps moving, which is a little bit annoying.

@rebornix rebornix mentioned this issue Aug 31, 2016
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Sep 1, 2016

The bug was created in #11334 and technically this is done so I'll make this verified

@Tyriar Tyriar added verified Verification succeeded and removed verification-found Issue verification failed labels Sep 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
2 participants
@rebornix @Tyriar